Skip to content

Commit d7d6ed8

Browse files
nitzanjAmir Tocker
authored andcommitted
Call isHttpUrl() again after modifying source instead of relying on previous check.
1 parent 5b1eb03 commit d7d6ed8

File tree

1 file changed

+3
-3
lines changed
  • cloudinary-core/src/main/java/com/cloudinary

1 file changed

+3
-3
lines changed

cloudinary-core/src/main/java/com/cloudinary/Url.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ public String generate(String source) {
353353
String transformationStr = transformation().generate();
354354
String signature = "";
355355

356-
String[] finalizedSource = finalizeSource(source, httpSource, format, urlSuffix);
356+
String[] finalizedSource = finalizeSource(source, format, urlSuffix);
357357
source = finalizedSource[0];
358358
String sourceToSign = finalizedSource[1];
359359

@@ -404,11 +404,11 @@ public String generate(String source) {
404404
return url;
405405
}
406406

407-
private String[] finalizeSource(String source, boolean isHttpSource, String format, String urlSuffix) {
407+
private String[] finalizeSource(String source, String format, String urlSuffix) {
408408
source = StringUtils.mergeSlashesInUrl(source);
409409
String[] result = new String[2];
410410
String sourceToSign;
411-
if (isHttpSource) {
411+
if (StringUtils.isHttpUrl(source)) {
412412
source = SmartUrlEncoder.encode(source);
413413
sourceToSign = source;
414414
} else {

0 commit comments

Comments
 (0)