Skip to content

Commit c447b5c

Browse files
authored
Clone configuration in Url.clone()
1 parent 1fe5dba commit c447b5c

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

cloudinary-core/src/main/java/com/cloudinary/Url.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public Url(Cloudinary cloudinary) {
5252

5353
public Url clone() {
5454
Url cloned = cloudinary.url();
55-
55+
cloned.config.update(config.asMap());
5656
cloned.fallbackContent = this.fallbackContent;
5757
cloned.format = this.format;
5858
cloned.posterSource = this.posterSource;

cloudinary-core/src/test/java/com/cloudinary/test/CloudinaryTest.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.cloudinary.Cloudinary;
44
import com.cloudinary.ResponsiveBreakpoint;
55
import com.cloudinary.Transformation;
6+
import com.cloudinary.Url;
67
import com.cloudinary.transformation.*;
78
import com.cloudinary.utils.ObjectUtils;
89
import junitparams.JUnitParamsRunner;
@@ -1159,5 +1160,10 @@ public static Map<String, String> getUrlParameters(URI uri) throws UnsupportedEn
11591160
return params;
11601161
}
11611162

1162-
1163+
@Test
1164+
public void testUrlCloneConfig(){
1165+
// verify that secure (from url.config) is cloned as well:
1166+
Url url = cloudinary.url().cloudName("cloud").format("frmt").publicId("123").secure(true);
1167+
assertEquals("https://res.cloudinary.com/cloud/image/upload/123.frmt", url.clone().generate());
1168+
}
11631169
}

0 commit comments

Comments
 (0)