Skip to content

Commit 97f92ba

Browse files
authored
Add folder decoupling support
1 parent fd41e66 commit 97f92ba

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

cloudinary-core/src/main/java/com/cloudinary/Util.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
public class Util {
1212
static final String[] BOOLEAN_UPLOAD_OPTIONS = new String[]{"backup", "exif", "faces", "colors", "image_metadata", "use_filename", "unique_filename",
1313
"eager_async", "invalidate", "discard_original_filename", "overwrite", "phash", "return_delete_token", "async", "quality_analysis", "cinemagraph_analysis",
14-
"accessibility_analysis"};
14+
"accessibility_analysis", "use_filename_as_display_name"};
1515

1616
@SuppressWarnings({"rawtypes", "unchecked"})
1717
public static final Map<String, Object> buildUploadParams(Map options) {
@@ -36,6 +36,9 @@ public static final Map<String, Object> buildUploadParams(Map options) {
3636
params.put("moderation", options.get("moderation"));
3737
params.put("access_mode", (String) options.get("access_mode"));
3838
params.put("filename_override", (String) options.get("filename_override"));
39+
params.put("public_id_prefix", (String) options.get("public_id_prefix"));
40+
params.put("asset_folder", (String) options.get("asset_folder"));
41+
params.put("display_name", (String) options.get("display_name"));
3942

4043
Object responsive_breakpoints = options.get("responsive_breakpoints");
4144
if (responsive_breakpoints != null) {

cloudinary-test-common/src/main/java/com/cloudinary/test/AbstractUploaderTest.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -794,4 +794,19 @@ private void addToDeleteList(String type, String id) {
794794

795795
ids.add(id);
796796
}
797+
798+
@Test
799+
public void testUploadFolderDecoupling() {
800+
//TODO: Need to build a unit testing infrastructure
801+
Map options = asMap(
802+
"use_filename_as_display_name", true,
803+
"public_id_prefix", "test_id_prefix",
804+
"asset_folder", "asset_folder_test",
805+
"display_name", "display_name_test");
806+
Map uploadParams = Util.buildUploadParams(options);
807+
Assert.assertEquals("test_id_prefix", uploadParams.get("public_id_prefix"));
808+
Assert.assertEquals(true, uploadParams.get("use_filename_as_display_name"));
809+
Assert.assertEquals("asset_folder_test", uploadParams.get("asset_folder"));
810+
Assert.assertEquals("display_name_test", uploadParams.get("display_name"));
811+
}
797812
}

0 commit comments

Comments
 (0)