Skip to content

Commit 7842e9a

Browse files
Support type parameter in Uploader.updateMetadata() (#226)
1 parent 922d42d commit 7842e9a

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

cloudinary-core/src/main/java/com/cloudinary/Uploader.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -532,6 +532,7 @@ public Map updateMetadata(Map metadata, String[] publicIds, Map options) throws
532532
Map<String, Object> params = new HashMap<String, Object>();
533533
params.put("metadata", Util.encodeContext(metadata));
534534
params.put("public_ids", Arrays.asList(publicIds));
535+
params.put("type", (String)options.get("type"));
535536

536537
return callApi("metadata", params, options, null);
537538
}

cloudinary-test-common/src/main/java/com/cloudinary/test/AbstractStructuredMetadataTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
public abstract class AbstractStructuredMetadataTest extends MockableTest {
1919
private static final String METADATA_UPLOADER_TAG = SDK_TEST_TAG + "_uploader";
2020
private static final String PUBLIC_ID = "before_class_public_id" + SUFFIX;
21+
private static final String PRIVATE_PUBLIC_ID = "before_class_private_public_id" + SUFFIX;
2122
protected Api api;
2223
public static final List<String> metadataFieldExternalIds = new ArrayList<String>();
2324

@@ -29,6 +30,7 @@ public static void setUpClass() throws IOException {
2930
}
3031

3132
cloudinary.uploader().upload(SRC_TEST_IMAGE, asMap("public_id", PUBLIC_ID));
33+
cloudinary.uploader().upload(SRC_TEST_IMAGE, asMap("public_id", PRIVATE_PUBLIC_ID, "type", "private"));
3234
}
3335

3436
@AfterClass
@@ -226,6 +228,10 @@ public void testUploaderUpdateMetadata() throws Exception {
226228
Map result = cloudinary.uploader().updateMetadata(Collections.<String, Object>singletonMap(fieldId, "123456"), new String[]{PUBLIC_ID}, null);
227229
assertNotNull(result);
228230
assertEquals(PUBLIC_ID, ((List) result.get("public_ids")).get(0).toString());
231+
//test updateMetadata for private asset
232+
Map result2 = cloudinary.uploader().updateMetadata(Collections.<String, Object>singletonMap(fieldId, "123456"), new String[]{PRIVATE_PUBLIC_ID}, asMap("type","private"));
233+
assertNotNull(result);
234+
assertEquals(PRIVATE_PUBLIC_ID, ((List) result2.get("public_ids")).get(0).toString());
229235
}
230236

231237
@Test

0 commit comments

Comments
 (0)