Skip to content

Commit 25416e7

Browse files
author
Amir Tocker
committed
Use variables for public_id's in rename tests.
1 parent 29270d4 commit 25416e7

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

cloudinary-test-common/src/main/java/com/cloudinary/test/AbstractUploaderTest.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,19 +116,21 @@ public void testUploadUTF8() throws IOException {
116116
public void testRename() throws Exception {
117117
Map result = cloudinary.uploader().upload(SRC_TEST_IMAGE, ObjectUtils.emptyMap());
118118

119-
cloudinary.uploader().rename((String) result.get("public_id"), result.get("public_id")+"2", ObjectUtils.emptyMap());
120-
assertNotNull(cloudinary.api().resource(result.get("public_id")+"2", ObjectUtils.emptyMap()));
119+
Object publicId = result.get("public_id");
120+
String publicId2 = "folder/" + publicId + "2";
121+
cloudinary.uploader().rename((String) publicId, publicId2, ObjectUtils.emptyMap());
122+
assertNotNull(cloudinary.api().resource(publicId2, ObjectUtils.emptyMap()));
121123

122124
Map result2 = cloudinary.uploader().upload("../cloudinary-test-common/src/main/resources/favicon.ico", ObjectUtils.emptyMap());
123125
boolean error_found=false;
124126
try {
125-
cloudinary.uploader().rename((String) result2.get("public_id"), result.get("public_id")+"2", ObjectUtils.emptyMap());
127+
cloudinary.uploader().rename((String) result2.get("public_id"), publicId2, ObjectUtils.emptyMap());
126128
} catch(Exception e) {
127129
error_found=true;
128130
}
129131
assertTrue(error_found);
130-
cloudinary.uploader().rename((String) result2.get("public_id"), result.get("public_id")+"2", ObjectUtils.asMap("overwrite", Boolean.TRUE));
131-
assertEquals(cloudinary.api().resource(result.get("public_id")+"2", ObjectUtils.emptyMap()).get("format"), "ico");
132+
cloudinary.uploader().rename((String) result2.get("public_id"), publicId2, ObjectUtils.asMap("overwrite", true));
133+
assertEquals(cloudinary.api().resource(publicId2, ObjectUtils.emptyMap()).get("format"), "ico");
132134
}
133135

134136
@Test

0 commit comments

Comments
 (0)