Merge branch 'feat/refactor-agents-base' of github.com:cloudflare/orange-builds into feat/refactor-agents-base

Author: AshishKumar4

worker/agents/core/behaviors/agentic.ts

@@ -227,10 +227,14 @@ export class AgenticCodingBehavior extends BaseCodingBehavior<AgenticState> impl
     }
 
     getOperationOptions(): OperationOptions<AgenticGenerationContext> {
+        const context = GenerationContext.from(this.state, this.getTemplateDetails(), this.logger);
+        if (!GenerationContext.isAgentic(context)) {
+            throw new Error('Expected AgenticGenerationContext');
+        }
         return {
             env: this.env,
             agentId: this.getAgentId(),
-            context: GenerationContext.from(this.state, this.getTemplateDetails(), this.logger) as AgenticGenerationContext,
+            context,
             logger: this.logger,
             inferenceContext: this.getInferenceContext(),
             agent: this

worker/agents/core/behaviors/phasic.ts

@@ -199,10 +199,14 @@ export class PhasicCodingBehavior extends BaseCodingBehavior<PhasicState> implem
     }
 
     getOperationOptions(): OperationOptions<PhasicGenerationContext> {
+        const context = GenerationContext.from(this.state, this.getTemplateDetails(), this.logger);
+        if (!GenerationContext.isPhasic(context)) {
+            throw new Error('Expected PhasicGenerationContext');
+        }
         return {
             env: this.env,
             agentId: this.getAgentId(),
-            context: GenerationContext.from(this.state, this.getTemplateDetails(), this.logger) as PhasicGenerationContext,
+            context,
             logger: this.logger,
             inferenceContext: this.getInferenceContext(),
             agent: this

worker/agents/core/stateMigration.ts

@@ -233,8 +233,14 @@ export class StateMigration {
             if (hasTemplateDetails) {
                 delete stateWithDeprecated.templateDetails;
             }
+            let migratedBehaviorType = state.behaviorType;
             if (isStateWithAgentMode(state)) {
-                delete stateWithDeprecated.agentMode;
+                migratedBehaviorType = state.agentMode === 'smart' ? 'agentic' : 'phasic';
+                needsMigration = true;
+                logger.info('Migrating agentMode to behaviorType', { 
+                    oldMode: state.agentMode, 
+                    newType: migratedBehaviorType 
+                });
             }
 
             return newState;

worker/agents/operations/AgenticProjectBuilder.ts

@@ -152,7 +152,8 @@ export class AgenticProjectBuilderOperation extends AgentOperationWithTools<
 
         const hasFiles = (filesIndex || []).length > 0;
         const isAgenticBlueprint = (bp?: Blueprint): bp is AgenticBlueprint => {
-            return !!bp && Array.isArray((bp as any).plan);
+            if (!bp) return false;
+            return 'plan' in bp && Array.isArray(bp.plan);
         };
         const hasTSX = filesIndex?.some(f => /\.(t|j)sx$/i.test(f.filePath)) || false;
         const hasMD = filesIndex?.some(f => /\.(md|mdx)$/i.test(f.filePath)) || false;