Skip to content

Commit 231bbf6

Browse files
CODEOWNER and chore assignee changes (#26379)
* CODEOWNER and chore assignee changes * Codeowner action fixes * Only call assignees API if array > 0 * Rebuild action assign-pr --------- Co-authored-by: Pedro Sousa <680496+pedrosousa@users.noreply.github.com>
1 parent a1655ec commit 231bbf6

File tree

7 files changed

+26
-38
lines changed

7 files changed

+26
-38
lines changed

.github/CODEOWNERS

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,8 @@ src/content/docs/smart-shield/ @RebeccaTamachiro @cloudflare/pcx-technical-writi
200200

201201
# Reference architecture
202202

203-
/src/content/docs/reference-architecture/ @securitypedant @haleycode @cloudflare/pcx-technical-writing
204-
/src/assets/images/reference-architecture/ @securitypedant @haleycode @cloudflare/pcx-technical-writing
203+
/src/content/docs/reference-architecture/ @securitypedant @cloudflare/pcx-technical-writing
204+
/src/assets/images/reference-architecture/ @securitypedant @cloudflare/pcx-technical-writing
205205

206206
# Security products
207207

.github/actions/assign-pr/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/actions/assign-pr/index.ts

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -78,24 +78,18 @@ async function list(
7878
}
7979
}
8080
}
81-
82-
if (assignees.size === 0) {
83-
// assign folks which will manually reassign
84-
["haleycode", "pedrosousa", "dcpena", "patriciasantaana"].forEach(
85-
(username) => assignees.add(username),
86-
);
87-
}
88-
8981
// don't self-assign
9082
assignees.delete(author);
9183

9284
try {
93-
await client.rest.issues.addAssignees({
94-
repo: repository.name,
95-
owner: repository.owner.login,
96-
issue_number: prnumber,
97-
assignees: [...assignees],
98-
});
85+
if (assignees.size > 0) {
86+
await client.rest.issues.addAssignees({
87+
repo: repository.name,
88+
owner: repository.owner.login,
89+
issue_number: prnumber,
90+
assignees: [...assignees],
91+
});
92+
}
9993
} catch (error) {
10094
core.setFailed(error.message);
10195
}

.github/actions/issue-label-assign/index.js

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/actions/issue-label-assign/index.ts

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -65,22 +65,16 @@ import * as codeOwnersUtils from "codeowners-utils";
6565
}
6666
console.log("Assignees are:");
6767
console.log(assignees);
68-
69-
if (assignees.size === 0) {
70-
// assign folks which will manually reassign
71-
["haleycode", "pedrosousa", "dcpena", "patriciasantaana"].forEach(
72-
(username) => assignees.add(username),
73-
);
74-
}
75-
7668
const client = github.getOctokit(token);
7769

78-
await client.rest.issues.addAssignees({
79-
owner: repository.owner.login,
80-
issue_number: issue.number,
81-
repo: repository.name,
82-
assignees: [...assignees],
83-
});
70+
if (assignees.size > 0) {
71+
await client.rest.issues.addAssignees({
72+
owner: repository.owner.login,
73+
issue_number: issue.number,
74+
repo: repository.name,
75+
assignees: [...assignees],
76+
});
77+
}
8478

8579
console.log("Assignees added (if present)");
8680

.github/workflows/anchor-link-audit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,4 +57,4 @@ jobs:
5757
curl --silent -X POST -H "Authorization: Bearer $GITHUB_TOKEN" \
5858
-H "Accept: application/vnd.github+json" \
5959
"https://api.github.com/repos/$GITHUB_REPOSITORY/issues" \
60-
-d "{\"title\": \"Broken Header Links Found\", \"body\": \"$(cat issue_body.txt)\", \"assignees\": [\"haleycode\"]}"
60+
-d "{\"title\": \"Broken Header Links Found\", \"body\": \"$(cat issue_body.txt)\"}"

.github/workflows/image-audit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,4 @@ jobs:
4949
curl --silent -X POST -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
5050
-H "Accept: application/vnd.github+json" \
5151
"https://api.github.com/repos/cloudflare/cloudflare-docs/issues" \
52-
-d "{\"title\": \"Unused Image Files Found\", \"body\": \"$(cat unused_files.txt)\", \"assignees\": [\"haleycode\"]}"
52+
-d "{\"title\": \"Unused Image Files Found\", \"body\": \"$(cat unused_files.txt)\"}"

0 commit comments

Comments
 (0)