CLJS-1744: rest produces nil for larger maps

remove rest logic from create-inod-seq, add rest logic where it belongs in both NodeSeq & ArrayNodeSeq

Author: swannodette

src/main/cljs/cljs/core.cljs

@@ -6999,9 +6999,10 @@ reduces them without incurring seq initialization"
       (first s)))
 
   (-rest [coll]
-    (if (nil? s)
-      (create-inode-seq nodes (+ i 2) nil)
-      (create-inode-seq nodes i (next s))))
+    (let [ret (if (nil? s)
+                (create-inode-seq nodes (+ i 2) nil)
+                (create-inode-seq nodes i (next s)))]
+      (if-not (nil? ret) ret ())))
 
   ISeqable
   (-seq [this] this)
@@ -7032,8 +7033,7 @@ reduces them without incurring seq initialization"
                  (if-let [node-seq (.inode-seq node)]
                    (NodeSeq. nil nodes (+ j 2) node-seq nil)
                    (recur (+ j 2)))
-                 (recur (+ j 2))))
-             ())))
+                 (recur (+ j 2)))))))
        (NodeSeq. nil nodes i s nil))))
 
 (deftype ArrayNodeSeq [meta nodes i s ^:mutable __hash]
@@ -7066,7 +7066,9 @@ reduces them without incurring seq initialization"
   ISequential
   ISeq
   (-first [coll] (first s))
-  (-rest  [coll] (create-array-node-seq nil nodes i (next s)))
+  (-rest  [coll]
+    (let [ret (create-array-node-seq nil nodes i (next s))]
+      (if-not (nil? ret) ret ())))
 
   ISeqable
   (-seq [this] this)

src/test/cljs/cljs/core_test.cljs

@@ -3230,6 +3230,11 @@
            rest rest rest rest rest rest rest rest rest)
          ())))
 
+(deftest test-cljs-1744
+  (doseq [i (range 1 64)]
+    (let [m (zipmap (range i) (range i))]
+      (is (= () (last (take (inc i) (iterate rest m))))))))
+
 (comment
   ;; ObjMap
   ;; (let [ks (map (partial str "foo") (range 500))