From d0427ffdbb4b3d5884962312be9f731eaef2c335 Mon Sep 17 00:00:00 2001 From: Jsp <98713940+JspIIV@users.noreply.github.com> Date: Tue, 1 Sep 2026 11:21:23 +0300 Subject: [PATCH] fix(types): drop the signer-local feature gating a mandatory dependency arc-consensus-types does not build with --no-default-features: error[E0432]: unresolved import `malachitebft_signing_ed25519` --> crates/types/src/proposal_part.rs:26:5 --> crates/types/src/codec/proto.rs:28:5 --> crates/types/src/signing.rs:21:9 --> crates/types/src/ssz/v1/vote.rs:21:5 signer-local marks malachitebft-signing-ed25519 optional, but those four modules import it unconditionally, so the crate cannot compile without it. The feature offers no optionality: nothing in the workspace names arc-consensus-types/signer-local, and there is no cfg(feature = "signer-local") anywhere in the tree. Make the dependency mandatory, which is what it already is, and remove the feature along with the default that enabled it. --- crates/types/Cargo.toml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/crates/types/Cargo.toml b/crates/types/Cargo.toml index d3b92e6..ef99f5c 100644 --- a/crates/types/Cargo.toml +++ b/crates/types/Cargo.toml @@ -8,10 +8,8 @@ rust-version.workspace = true publish.workspace = true [features] -default = ["signer-local"] arbitrary = ["dep:arbitrary"] byzantine = ["dep:malachitebft-engine-byzantine"] -signer-local = ["dep:malachitebft-signing-ed25519"] [dependencies] @@ -43,7 +41,7 @@ malachitebft-core-types = { workspace = true, features = ["serde"] } malachitebft-engine-byzantine = { workspace = true, optional = true } malachitebft-proto = { workspace = true } malachitebft-signing = { workspace = true } -malachitebft-signing-ed25519 = { workspace = true, optional = true, features = ["rand", "serde"] } +malachitebft-signing-ed25519 = { workspace = true, features = ["rand", "serde"] } malachitebft-sync = { workspace = true } prost = { workspace = true }