minor test fixes & cleanup

Author: codemasher

tests/Core/OAuthProviderFactoryTest.php

@@ -0,0 +1,60 @@
+<?php
+/**
+ * Class OAuthProviderFactoryTest
+ *
+ * @created      11.04.2024
+ * @author       smiley <smiley@chillerlan.net>
+ * @copyright    2024 smiley
+ * @license      MIT
+ *
+ * @phan-file-suppress PhanUndeclaredProperty
+ */
+declare(strict_types=1);
+
+namespace chillerlan\OAuthTest\Core;
+
+use chillerlan\OAuth\Core\OAuthInterface;
+use chillerlan\OAuth\OAuthProviderFactory;
+use chillerlan\OAuth\Providers\ProviderException;
+use chillerlan\OAuthTest\Providers\DummyOAuth1Provider;
+use chillerlan\OAuthTest\Providers\ProviderUnitTestHttpClientFactory;
+use chillerlan\PHPUnitHttp\HttpFactoryTrait;
+use PHPUnit\Framework\TestCase;
+use function realpath;
+
+/**
+ *
+ */
+class OAuthProviderFactoryTest extends TestCase{
+	use HttpFactoryTrait;
+
+	protected const CACERT = __DIR__.'/../cacert.pem';
+
+	protected string $HTTP_CLIENT_FACTORY = ProviderUnitTestHttpClientFactory::class;
+
+	protected function setUp():void{
+		$this->initFactories(realpath($this::CACERT));
+
+		$this->providerFactory = new OAuthProviderFactory(
+			$this->httpClient,
+			$this->requestFactory,
+			$this->streamFactory,
+			$this->uriFactory,
+		);
+
+	}
+
+	public function testGetProvider():void{
+		$provider = $this->providerFactory->getProvider(DummyOAuth1Provider::class);
+
+		$this::assertInstanceOf(OAuthInterface::class, $provider);
+	}
+
+	public function testGetProviderInvalidProviderClassException():void{
+		$this->expectException(ProviderException::class);
+		$this->expectExceptionMessage('invalid provider class given');
+
+		$this->providerFactory->getProvider('\\some\\unknown\\class');
+	}
+
+}

tests/Core/UtilitiesTest.php

@@ -14,7 +14,7 @@
 use chillerlan\OAuth\Core\{OAuthInterface, Utilities};
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
-use ReflectionClass;
+use InvalidArgumentException, ReflectionClass;
 
 /**
  *
@@ -37,6 +37,13 @@ public function testGetProvidersWithGivenPath():void{
 		}
 	}
 
+	public function testGetProvidersInvalidPathException():void{
+		$this->expectException(InvalidArgumentException::class);
+		$this->expectExceptionMessage('invalid $providerDir');
+
+		Utilities::getProviders('/foo');
+	}
+
 	public static function encryptionFormatProvider():array{
 		return [
 			'binary' => [Utilities::ENCRYPT_FORMAT_BINARY],

tests/Providers/DummyOAuth1Provider.php

@@ -18,6 +18,8 @@
  */
 final class DummyOAuth1Provider extends OAuth1Provider implements TokenInvalidate{
 
+	public const IDENTIFIER = 'DUMMYOAUTH1PROVIDER';
+
 	public const HEADERS_AUTH = ['foo' => 'bar'];
 	public const HEADERS_API  = ['foo' => 'bar'];
 

tests/Providers/DummyOAuth2Provider.php

@@ -18,6 +18,8 @@
  */
 final class DummyOAuth2Provider extends OAuth2Provider implements ClientCredentials, CSRFToken, PKCE, TokenRefresh, TokenInvalidate{
 
+	public const IDENTIFIER = 'DUMMYOAUTH2PROVIDER';
+
 	public const AUTH_METHOD  = self::AUTH_METHOD_QUERY;
 	public const HEADERS_AUTH = ['foo' => 'bar'];
 	public const HEADERS_API  = ['foo' => 'bar'];

tests/Providers/Live/AmazonAPITest.php

@@ -30,7 +30,7 @@ protected function assertMeResponse(AuthenticatedUser $user):void{
 		$this::assertMatchesRegularExpression('/[a-z\d.]+/i', $user->id);
 	}
 
-	public function testUnauthorizedAccessException():void{
+	public function testMeUnauthorizedAccessException():void{
 		$token                    = $this->storage->getAccessToken($this->provider->name);
 		// avoid refresh
 		$token->expires           = AccessToken::NEVER_EXPIRES;

tests/Providers/Live/OAuthProviderLiveTestAbstract.php

@@ -68,7 +68,7 @@ protected function assertUnauthorizedAccessException(AccessToken $token):void{
 		$this->provider->me();
 	}
 
-	public function testUnauthorizedAccessException():void{
+	public function testMeUnauthorizedAccessException():void{
 
 		if(!$this->provider instanceof UserInfo){
 			$this::markTestSkipped('AuthenticatedUser N/A');

tests/Providers/Live/SteamAPITest.php

@@ -35,7 +35,7 @@ protected function setUp():void{
 		$this->id = $token->extraParams['id_int']; // SteamID64
 	}
 
-	public function testUnauthorizedAccessException():void{
+	public function testMeUnauthorizedAccessException():void{
 		$this::markTestSkipped('N/A');
 	}
 

tests/Providers/Live/TwitterCCAPITest.php

@@ -24,7 +24,7 @@ protected function getProviderFQCN():string{
 		return TwitterCC::class;
 	}
 
-	public function testUnauthorizedAccessException():void{
+	public function testMeUnauthorizedAccessException():void{
 		$this::markTestSkipped('N/A');
 	}
 

tests/Providers/Unit/OAuthProviderUnitTestAbstract.php

@@ -52,6 +52,9 @@ public function testMagicGet():void{
 		$this::assertNull($this->provider->foo);
 	}
 
+	public function testIdentifierIsNonEmpty():void{
+		$this::assertNotEmpty($this->provider::IDENTIFIER);
+	}
 
 	/*
 	 * request body