Small refactoring

Author: cheprasov

src/RedisClient/Client/AbstractRedisClient.php

@@ -48,7 +48,7 @@ abstract class AbstractRedisClient {
             'clusters' => [],
             'init_on_start' => false,
             'init_on_error_moved' => false,
-            'timeout_on_error_tryagain' => 0.25,
+            'timeout_on_error_tryagain' => 0.05,
         ],
     ];
 
@@ -102,12 +102,22 @@ protected function getConfig($param = null) {
         return isset($this->config[$param]) ? $this->config[$param] : null;
     }
 
+    /**
+     * @param AbstractRedisClient $RedisClient
+     * @param $config
+     * @return \RedisClient\Protocol\ProtocolInterface
+     */
+    protected function createProtocol(AbstractRedisClient $RedisClient, $config)
+    {
+        return ProtocolFactory::createRedisProtocol($RedisClient, $config);
+    }
+
     /**
      * @return ProtocolInterface
      */
     protected function getProtocol() {
         if (!$this->Protocol) {
-            $this->Protocol = ProtocolFactory::createRedisProtocol($this, $this->getConfig());
+            $this->Protocol = $this->createProtocol($this, $this->getConfig());
             if ($this->ClusterMap) {
                 $this->ClusterMap->addProtocol($this->Protocol);
             }
@@ -177,7 +187,7 @@ protected function executeProtocolCommand(ProtocolInterface $Protocol, array $co
             if ($response instanceof AskResponseException) {
                 $config = $this->getConfig();
                 $config['server'] = $response->getServer();
-                $TempRedisProtocol = ProtocolFactory::createRedisProtocol($this, $config);
+                $TempRedisProtocol = $this->createProtocol($this, $config);
                 $TempRedisProtocol->send(['ASKING']);
                 return $this->executeProtocolCommand($TempRedisProtocol, $command, $params);
             }
@@ -291,6 +301,7 @@ public function executeRaw($structure) {
     }
 
     /**
+     * @deprecated
      * Command will parsed by the client, before sent to server
      * @param string $command
      * @return mixed
@@ -300,6 +311,7 @@ public function executeRawString($command) {
     }
 
     /**
+     * @deprecated
      * @param string $command
      * @return string[]
      */

src/RedisClient/ClientFactory.php

@@ -25,6 +25,7 @@ class ClientFactory {
     const REDIS_VERSION_3x0 = '3.0';
     const REDIS_VERSION_3x2 = '3.2';
     const REDIS_VERSION_4x0 = '4.0';
+    const REDIS_VERSION_DEFAULT = self::REDIS_VERSION_3x2;
 
     /**
      * @var string|null
@@ -46,7 +47,7 @@ class ClientFactory {
      * @return string
      */
     public static function getDefaultRedisVersion() {
-        return self::$defaultRedisVersion ?: self::REDIS_VERSION_3x2;
+        return self::$defaultRedisVersion ?: self::REDIS_VERSION_DEFAULT;
     }
 
     /**