[MERGE #6287 @zenparsing] [test262] Enable function name inference flag by default

Kevin Smith · Kevin Smith · commit 7e29961eb355 · 2019-09-23T11:24:22.000-07:00
Merge pull request #6287 from zenparsing:test262-enable-fn-name There are many tests for function name inference. Does anyone know a reason why this flag was never turned on?
diff --git a/lib/Common/ConfigFlagsList.h b/lib/Common/ConfigFlagsList.h
@@ -635,14 +635,7 @@ PHASE(All)
 #define DEFAULT_CONFIG_ES6DefaultArgs          (true)
 #define DEFAULT_CONFIG_ES6Destructuring        (true)
 #define DEFAULT_CONFIG_ES6ForLoopSemantics     (true)
-
-#ifdef COMPILE_DISABLE_ES6FunctionNameFull
-    // If ES6FunctionNameFull needs to be disabled by compile flag, COMPILE_DISABLE_ES6FunctionNameFull should be false
-    #define DEFAULT_CONFIG_ES6FunctionNameFull     (false)
-#else
-    #define DEFAULT_CONFIG_ES6FunctionNameFull     (false)
-#endif
-
+#define DEFAULT_CONFIG_ES6FunctionNameFull     (true)
 #define DEFAULT_CONFIG_ES6Generators           (true)
 #define DEFAULT_CONFIG_ES6IsConcatSpreadable   (true)
 #define DEFAULT_CONFIG_ES6Math                 (true)
@@ -1143,12 +1136,7 @@ FLAGPR           (Boolean, ES6, ES6DateParseFix        , "Enable ES6 Date.parse
 FLAGPR           (Boolean, ES6, ES6DefaultArgs         , "Enable ES6 Default Arguments"                             , DEFAULT_CONFIG_ES6DefaultArgs)
 FLAGPR           (Boolean, ES6, ES6Destructuring       , "Enable ES6 Destructuring"                                 , DEFAULT_CONFIG_ES6Destructuring)
 FLAGPR           (Boolean, ES6, ES6ForLoopSemantics    , "Enable ES6 for loop per iteration bindings"               , DEFAULT_CONFIG_ES6ForLoopSemantics)
-
-#ifndef COMPILE_DISABLE_ES6FunctionNameFull
-    #define COMPILE_DISABLE_ES6FunctionNameFull 0
-#endif
-FLAGPR_REGOVR_EXP(Boolean, ES6, ES6FunctionNameFull    , "Enable ES6 Full function.name"                            , DEFAULT_CONFIG_ES6FunctionNameFull)
-
+FLAGPR           (Boolean, ES6, ES6FunctionNameFull    , "Enable ES6 Full function.name"                            , DEFAULT_CONFIG_ES6FunctionNameFull)
 FLAGPR           (Boolean, ES6, ES6Generators          , "Enable ES6 generators"                                    , DEFAULT_CONFIG_ES6Generators)
 FLAGPR           (Boolean, ES6, ES7ExponentiationOperator, "Enable ES7 exponentiation operator (**)"                , DEFAULT_CONFIG_ES7ExponentionOperator)
 
diff --git a/test/Debugger/dumpFunctionProperties.js.dbg.baseline b/test/Debugger/dumpFunctionProperties.js.dbg.baseline
@@ -85,7 +85,7 @@
       {
         "#__proto__": "function <large string>",
         "prototype": "Object {...}",
-        "name": "string ",
+        "name": "string Global code",
         "caller": "object null",
         "arguments": "object null",
         "length": "number -1"
@@ -149,11 +149,11 @@
       {
         "#__proto__": "function <large string>",
         "prototype": "Object {...}",
-        "name": "string ",
+        "name": "string Global code",
         "caller": "object null",
         "arguments": "object null",
         "length": "number -1"
       }
     ]
   }
-]
+]
diff --git a/test/DebuggerCommon/attachWithDeferParse.js.dbg.baseline b/test/DebuggerCommon/attachWithDeferParse.js.dbg.baseline
@@ -86,7 +86,7 @@
         "#__proto__": "function <large string>",
         "prototype": "Object {...}",
         "length": "number 2",
-        "name": "string ",
+        "name": "string s",
         "caller": "object null",
         "arguments": "object null"
       },
@@ -113,4 +113,4 @@
       "inEvalFunc1": "function <large string>"
     }
   }
-]
+]
diff --git a/test/DebuggerCommon/catchInspection.js.dbg.baseline b/test/DebuggerCommon/catchInspection.js.dbg.baseline
@@ -140,7 +140,7 @@
         "#__proto__": "function <large string>",
         "prototype": "Object {...}",
         "length": "number 0",
-        "name": "string ",
+        "name": "string j1",
         "caller": "object null",
         "arguments": "object null"
       }
@@ -594,7 +594,7 @@
         "#__proto__": "function <large string>",
         "prototype": "Object {...}",
         "length": "number 0",
-        "name": "string ",
+        "name": "string startTest",
         "caller": "object null",
         "arguments": "object null"
       },

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@`
`85`	`85`	`{`
`86`	`86`	`"#__proto__": "function <large string>",`
`87`	`87`	`"prototype": "Object {...}",`
`88`		`- "name": "string ",`
	`88`	`+ "name": "string Global code",`
`89`	`89`	`"caller": "object null",`
`90`	`90`	`"arguments": "object null",`
`91`	`91`	`"length": "number -1"`
`@@ -149,11 +149,11 @@`
`149`	`149`	`{`
`150`	`150`	`"#__proto__": "function <large string>",`
`151`	`151`	`"prototype": "Object {...}",`
`152`		`- "name": "string ",`
	`152`	`+ "name": "string Global code",`
`153`	`153`	`"caller": "object null",`
`154`	`154`	`"arguments": "object null",`
`155`	`155`	`"length": "number -1"`
`156`	`156`	`}`
`157`	`157`	`]`
`158`	`158`	`}`
`159`		`-]`
	`159`	`+]`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@`
`86`	`86`	`"#__proto__": "function <large string>",`
`87`	`87`	`"prototype": "Object {...}",`
`88`	`88`	`"length": "number 2",`
`89`		`- "name": "string ",`
	`89`	`+ "name": "string s",`
`90`	`90`	`"caller": "object null",`
`91`	`91`	`"arguments": "object null"`
`92`	`92`	`},`
`@@ -113,4 +113,4 @@`
`113`	`113`	`"inEvalFunc1": "function <large string>"`
`114`	`114`	`}`
`115`	`115`	`}`
`116`		`-]`
	`116`	`+]`