Skip to content

Commit 4e53160

Browse files
authored
Merge pull request #81 from cardmagic/fix/rails-71-busy-wait-test
Fix the Rails 7.1 unrestorable busy wait test
2 parents 106dbf0 + 445cf27 commit 4e53160

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

‎.github/workflows/ci.yml‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88
jobs:
99
sqlite:
1010
runs-on: ubuntu-latest
11+
timeout-minutes: 15
1112
steps:
1213
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
1314
- uses: ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b # v1
@@ -19,6 +20,7 @@ jobs:
1920

2021
javascript:
2122
runs-on: ubuntu-latest
23+
timeout-minutes: 15
2224
steps:
2325
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
2426
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
@@ -31,6 +33,7 @@ jobs:
3133

3234
compatibility:
3335
runs-on: ubuntu-latest
36+
timeout-minutes: 15
3437
strategy:
3538
fail-fast: false
3639
matrix:
@@ -49,6 +52,7 @@ jobs:
4952

5053
redis:
5154
runs-on: ubuntu-latest
55+
timeout-minutes: 15
5256
services:
5357
redis:
5458
image: redis:7
@@ -69,6 +73,7 @@ jobs:
6973

7074
postgresql:
7175
runs-on: ubuntu-latest
76+
timeout-minutes: 15
7277
services:
7378
postgres:
7479
image: postgres:18
@@ -95,6 +100,7 @@ jobs:
95100

96101
mysql:
97102
runs-on: ubuntu-latest
103+
timeout-minutes: 15
98104
# Both clients speak MySQL but report different adapter names, negotiate
99105
# different connection collations, and name the same error code
100106
# differently, so passing on one proves nothing about the other.
@@ -129,6 +135,7 @@ jobs:
129135

130136
static:
131137
runs-on: ubuntu-latest
138+
timeout-minutes: 15
132139
steps:
133140
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
134141
- uses: ruby/setup-ruby@95ef2b042f9d7a56d8268cba8559e2842e2ad01b # v1
@@ -148,6 +155,7 @@ jobs:
148155
- compatibility
149156
- redis
150157
runs-on: ubuntu-latest
158+
timeout-minutes: 15
151159
permissions:
152160
contents: write
153161
id-token: write

‎test/integration/synchronous_invocation_test.rb‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -588,7 +588,10 @@ def wait(timeout:)
588588
database_adapter = SolidObjects.database_adapter
589589
database_adapter.define_singleton_method(:configured_busy_handler_timeout) { |_connection| nil }
590590

591-
SolidObjects::Record.connection_pool.with_connection do
591+
SolidObjects::Record.connection_pool.with_connection do |connection|
592+
connection.raw_connection.busy_handler_timeout = configured_sqlite_busy_handler_timeout
593+
assert_equal 0, connection.select_value("PRAGMA busy_timeout").to_i
594+
592595
CounterActor.ref("unrestorable").increment
593596

594597
assert_nothing_raised do

0 commit comments

Comments
 (0)