Repository navigation
Commit 30bf741
committed
fix: Share the portable event contract
A parity audit found portable events with different names and fields in
Ruby and JavaScript. Only the timeout event had a shared fixture, so no
test found the difference.
compatibility/telemetry-events.json now holds the attribute allowlist
and the exact keys of each core SQL event. Both test suites read the
same file.
- Rename payload_broadcast_failed to payload_broadcast.failed, the
dotted form that all other events use.
- Send operation, deliveryMode, retryable, outcome, commitAction, and
the outbox identity, as JavaScript already does.
- Log exporter and observer failures. Ruby discarded them before.
- Require an observer block and accept at most 1,000 observers.
- Pin reserved JSON keys through actor arguments, state, and results.1 parent 6771a76 commit 30bf741
30 files changed
Lines changed: 886 additions & 64 deletions
File tree
- compatibility
- docs
- lib
- solid_objects
- sig
- generated/lib
- solid_objects
- support
- test
- integration
- unit
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
5 | 21 | | |
6 | 22 | | |
7 | 23 | | |
| |||
0 commit comments