More refactoring of the weak-node-api generator
#330
+109
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
C++
Apple 🍎
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the weak-node-api package by renaming WeakNodeApiHost to NodeApiHost and reorganizing code generation. The changes improve code organization by separating the NodeApiHost struct generation into its own file and enhancing generated file documentation with structured comments.
Key changes:
- Renamed
WeakNodeApiHosttoNodeApiHostthroughout the codebase - Extracted
NodeApiHoststruct generation to a dedicated generator file - Added JSDoc-style file headers to all generated files
- Consolidated npm scripts with consistent naming conventions (e.g.,
prebuild:*prefix)
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/weak-node-api/tests/test_inject.cpp | Updated test references from WeakNodeApiHost to NodeApiHost |
| packages/weak-node-api/scripts/generators/weak-node-api.ts | Removed NodeApiHost struct generation, now imports from separate file |
| packages/weak-node-api/scripts/generators/NodeApiHost.ts | New file containing extracted NodeApiHost struct generation logic |
| packages/weak-node-api/scripts/generate.ts | Added file header generation with JSDoc comments for all output files |
| packages/weak-node-api/package.json | Renamed scripts to use consistent prebuild:* and generate naming |
| packages/weak-node-api/CMakeLists.txt | Added NodeApiHost.hpp to the list of public headers |
| packages/weak-node-api/.gitignore | Simplified to ignore entire /generated/ directory |
| packages/host/scripts/generate-injector.mts | Updated struct name from WeakNodeApiHost to NodeApiHost |
| packages/host/package.json | Renamed script to injector:generate for consistency |
| package.json | Removed unused prerelease script |
| .github/workflows/check.yml | Updated workflow to use renamed npm scripts |
| .changeset/slimy-parts-admire.md | Changeset documenting the rename |
kraenhansen
changed the title
weak-node-api generator
kraenhansen
force-pushed
the
kh/weak-node-api-refactored-generator-3
branch
from
cf5e056 to
bd952a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More refactoring (following up on #327 and #328), preparing for #329.