validate poll_oneoff in/out arrays against nsubscriptions#4964
Open
netliomax25-code wants to merge 1 commit into
Open
validate poll_oneoff in/out arrays against nsubscriptions#4964netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inand a single wasi_event_t atout, then hands the wasm-controllednsubscriptionsto the poll backend, which reads in[0..nsubscriptions) and writes out[0..nevents).in/outnear the end of its linear memory and passes nsubscriptions > 1, the trailing elements fall outside the validated range; on builds where hardware bounds checks are off and validate_native_addr is the active guard, that becomes an out-of-bounds read and write of memory next to the sandbox.inandoutarrays (sizeof * nsubscriptions), the way fd_read/fd_write/sock_recv already validate their iovec arrays. the libc-uvwasi wrapper carried the identical one-element check and gets the same fix.Checked with hardware bounds checks disabled so validate_native_addr is the active guard: before the change, a module calling poll_oneoff with
in/outone element from the page end and nsubscriptions=2 segfaults; after, the call returns an error and a normal single-subscription poll still returns 0.