Skip to content

Commit a86ba14

Browse files
authored
Merge pull request #16 from bybatkhuu/develop
🎨 Minor bug fixes.
2 parents 23b0d38 + 3ce59c7 commit a86ba14

File tree

9 files changed

+29
-22
lines changed

9 files changed

+29
-22
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ To run tests, run the following command:
373373
pip install -r ./requirements.test.txt
374374
375375
# Run tests:
376-
python -m pytest -sv
376+
python -m pytest -v
377377
```
378378

379379
## Environment Variables

beans_logging/__init__.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# -*- coding: utf-8 -*-
22

3-
from .schemas import LoggerConfigPM
43
from ._base import Logger, logger, LoggerLoader
4+
from .schemas import LoggerConfigPM
5+
from ._const import WarnEnum
56
from .__version__ import __version__

beans_logging/_base.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99

1010
## Third-party libraries
1111
import yaml
12-
from pydantic import validate_call
13-
from loguru._logger import Logger
1412
from loguru import logger
13+
from loguru._logger import Logger
14+
from pydantic import validate_call
1515

1616
## Internal modules
1717
from ._utils import create_dir, deep_merge
@@ -170,7 +170,6 @@ def update_config(self, config: Union[LoggerConfigPM, Dict[str, Any]]):
170170
if isinstance(config, dict):
171171
_config_dict = self.config.model_dump()
172172
_merged_dict = deep_merge(_config_dict, config)
173-
print(_merged_dict)
174173
try:
175174
self.config = LoggerConfigPM(**_merged_dict)
176175
except Exception:
@@ -470,7 +469,7 @@ def add_custom_handler(self, handler_name: str, **kwargs) -> int:
470469
_log_path = _log_path.format(app_name=self.config.app_name)
471470

472471
_logs_dir, _ = os.path.split(_log_path)
473-
create_dir(create_dir=_logs_dir, warn_mode="DEBUG")
472+
create_dir(create_dir=_logs_dir)
474473
kwargs["sink"] = _log_path
475474

476475
if "format" not in kwargs:

beans_logging/_const.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# -*- coding: utf-8 -*-
2+
3+
from enum import Enum
4+
5+
6+
class WarnEnum(str, Enum):
7+
RAISE = "RAISE"
8+
LOG = "LOG"
9+
DEBUG = "DEBUG"
10+
IGNORE = "IGNORE"

beans_logging/_utils.py

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,30 +4,27 @@
44
import copy
55
import errno
66

7-
# import logging
8-
9-
from pydantic import validate_call
107
from loguru import logger
8+
from pydantic import validate_call
119

12-
# logger = logging.getLogger(__name__)
10+
from ._const import WarnEnum
1311

1412

1513
@validate_call
16-
def create_dir(create_dir: str, warn_mode: str = "DEBUG"):
14+
def create_dir(create_dir: str, warn_mode: WarnEnum = WarnEnum.DEBUG):
1715
"""Create directory if `create_dir` doesn't exist.
1816
1917
Args:
2018
create_dir (str, required): Create directory path.
2119
warn_mode (str, optional): Warning message mode, for example: 'LOG', 'DEBUG', 'QUIET'. Defaults to "QUIET".
2220
"""
2321

24-
warn_mode = warn_mode.strip().upper()
2522
if not os.path.isdir(create_dir):
2623
try:
2724
_message = f"Creaing '{create_dir}' directory..."
28-
if warn_mode == "LOG":
25+
if warn_mode == WarnEnum.LOG:
2926
logger.info(_message)
30-
elif warn_mode == "DEBUG":
27+
elif warn_mode == WarnEnum.DEBUG:
3128
logger.debug(_message)
3229

3330
os.makedirs(create_dir)
@@ -39,9 +36,9 @@ def create_dir(create_dir: str, warn_mode: str = "DEBUG"):
3936
raise
4037

4138
_message = f"Successfully created '{create_dir}' directory."
42-
if warn_mode == "LOG":
39+
if warn_mode == WarnEnum.LOG:
4340
logger.success(_message)
44-
elif warn_mode == "DEBUG":
41+
elif warn_mode == WarnEnum.DEBUG:
4542
logger.debug(_message)
4643

4744

beans_logging/fastapi/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# -*- coding: utf-8 -*-
22

3-
from ._middlewares import HttpAccessLogMiddleware
4-
from ._handlers import add_http_file_handler, add_http_file_json_handler
53
from ._filters import use_http_filter
64
from ._formats import http_file_format, http_file_json_format
5+
from ._handlers import add_http_file_handler, add_http_file_json_handler
6+
from ._middlewares import HttpAccessLogMiddleware

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
PyYAML>=6.0.1,<7.0
22
pydantic>=2.1.1,<3.0.0
3-
loguru>=0.7.1,<1.0.0
3+
loguru>=0.7.2,<1.0.0

scripts/test.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,12 @@ main()
7878
fi
7979

8080
if [ "${_IS_VERBOSE}" == true ]; then
81-
_verbose_param="-vv"
81+
_verbose_param="-svv"
8282
fi
8383

8484
echoInfo "Running test..."
8585
# shellcheck disable=SC2086
86-
python -m pytest -sv ${_coverage_param} ${_logging_param} ${_verbose_param} || exit 2
86+
python -m pytest -v ${_coverage_param} ${_logging_param} ${_verbose_param} || exit 2
8787
echoOk "Done."
8888
}
8989

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
install_requires=[
3939
"PyYAML>=6.0,<7.0",
4040
"pydantic>=2.1.1,<3.0.0",
41-
"loguru>=0.7.1,<1.0.0",
41+
"loguru>=0.7.2,<1.0.0",
4242
],
4343
classifiers=[
4444
"Development Status :: 4 - Beta",

0 commit comments

Comments
 (0)