Skip to content

Commit 90955bd

Browse files
authored
Merge pull request #14 from bybatkhuu/develop
🎨 Minor update.
2 parents e2f7d98 + ae7d484 commit 90955bd

File tree

2 files changed

+39
-30
lines changed

2 files changed

+39
-30
lines changed

beans_logging/_base.py

Lines changed: 38 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ class LoggerLoader:
4747
_load_env_vars() : Load 'BEANS_LOGGING_CONFIG_PATH' environment variable for logger config file path.
4848
_load_config_file() : Load logger config from file.
4949
_check_env() : Check environment variables for logger config.
50+
_check_config() : Check logger config to update some options before loading handlers.
5051
_add_stream_std_handler() : Add std stream handler to logger.
5152
_add_file_log_handler() : Add log file handler to logger.
5253
_add_file_err_handler() : Add error log file handler to logger.
@@ -101,6 +102,7 @@ def load(self) -> Logger:
101102
self.remove_handler()
102103

103104
self._check_env()
105+
self._check_config()
104106

105107
if self.config.stream.std_handler.enabled:
106108
self._add_stream_std_handler()
@@ -286,6 +288,15 @@ def _check_env(self):
286288
if _is_debug and (self.config.level != "TRACE"):
287289
self.config.level = "DEBUG"
288290

291+
# if self.config.stream.use_color:
292+
# ## Checking terminal could support xterm colors:
293+
# _TERM = str(os.getenv("TERM")).strip()
294+
# if not "xterm" in _TERM:
295+
# self.config.stream.use_color = False
296+
297+
def _check_config(self):
298+
"""Check logger config to update some options before loading handlers."""
299+
289300
if self.config.level == "TRACE":
290301
self.config.use_diagnose = True
291302

@@ -294,11 +305,33 @@ def _check_env(self):
294305
"level_short:<5", "level.icon:<4"
295306
)
296307

297-
# if self.config.stream.use_color:
298-
# ## Checking terminal could support xterm colors:
299-
# _TERM = str(os.getenv("TERM")).strip()
300-
# if not "xterm" in _TERM:
301-
# self.config.stream.use_color = False
308+
if "{app_name}" in self.config.file.log_handlers.log_path:
309+
self.config.file.log_handlers.log_path = (
310+
self.config.file.log_handlers.log_path.format(
311+
app_name=self.config.app_name
312+
)
313+
)
314+
315+
if "{app_name}" in self.config.file.log_handlers.err_path:
316+
self.config.file.log_handlers.err_path = (
317+
self.config.file.log_handlers.err_path.format(
318+
app_name=self.config.app_name
319+
)
320+
)
321+
322+
if "{app_name}" in self.config.file.json_handlers.log_path:
323+
self.config.file.json_handlers.log_path = (
324+
self.config.file.json_handlers.log_path.format(
325+
app_name=self.config.app_name
326+
)
327+
)
328+
329+
if "{app_name}" in self.config.file.json_handlers.err_path:
330+
self.config.file.json_handlers.err_path = (
331+
self.config.file.json_handlers.err_path.format(
332+
app_name=self.config.app_name
333+
)
334+
)
302335

303336
def _add_stream_std_handler(self) -> int:
304337
"""Add std stream handler to logger.

beans_logging/schemas.py

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ def _check_log_path(self) -> "JsonHandlersPM":
9090

9191

9292
class FilePM(ExtraBaseModel):
93-
logs_dir: str = Field(
93+
logs_dir: constr(strip_whitespace=True) = Field(
9494
default=os.path.join(os.getcwd(), "logs"), min_length=2, max_length=4095
9595
)
9696
rotate_size: int = Field(
@@ -144,27 +144,3 @@ class LoggerConfigPM(ExtraBaseModel):
144144
file: FilePM = Field(default=FilePM())
145145
intercept: InterceptPM = Field(default=InterceptPM())
146146
extra: ExtraPM = Field(default=ExtraPM())
147-
148-
# @model_validator(mode="after")
149-
# def _check_log_path(self) -> "LoggerConfigPM":
150-
# if "{app_name}" in self.file.log_handlers.log_path:
151-
# self.file.log_handlers.log_path = self.file.log_handlers.log_path.format(
152-
# app_name=self.app_name
153-
# )
154-
155-
# if "{app_name}" in self.file.log_handlers.err_path:
156-
# self.file.log_handlers.err_path = self.file.log_handlers.err_path.format(
157-
# app_name=self.app_name
158-
# )
159-
160-
# if "{app_name}" in self.file.json_handlers.log_path:
161-
# self.file.json_handlers.log_path = self.file.json_handlers.log_path.format(
162-
# app_name=self.app_name
163-
# )
164-
165-
# if "{app_name}" in self.file.json_handlers.err_path:
166-
# self.file.json_handlers.err_path = self.file.json_handlers.err_path.format(
167-
# app_name=self.app_name
168-
# )
169-
170-
# return self

0 commit comments

Comments
 (0)