Skip to content

Commit 43c1f45

Browse files
committed
enter_bug: Fix hard BMO dependency (#29)
The default_platform and default_op_sys Bugzilla::Product methods are installed by the BMO extension, so don't attempt to invoke them when it isn't present.
1 parent 7c1a336 commit 43c1f45

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

enter_bug.cgi

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ use Bugzilla::Field;
3737
use Bugzilla::Status;
3838
use Bugzilla::UserAgent;
3939

40+
use List::Util qw(any);
41+
4042
my $user = Bugzilla->login(LOGIN_REQUIRED);
4143

4244
my $cloned_bug;
@@ -322,10 +324,15 @@ else {
322324
= formvalue('bug_severity', Bugzilla->params->{'defaultseverity'});
323325

324326
# BMO - use per-product default hw/os
325-
$default{'rep_platform'}
326-
= formvalue('rep_platform', $product->default_platform // detect_platform());
327-
$default{'op_sys'}
328-
= formvalue('op_sys', $product->default_op_sys // detect_op_sys());
327+
if (any { $_->NAME eq 'BMO' } @{ Bugzilla->extensions }) {
328+
$default{'rep_platform'}
329+
= formvalue('rep_platform', $product->default_platform // detect_platform());
330+
$default{'op_sys'}
331+
= formvalue('op_sys', $product->default_op_sys // detect_op_sys());
332+
} else {
333+
$default{'rep_platform'} = formvalue('rep_platform', detect_platform());
334+
$default{'op_sys'} = formvalue('op_sys', detect_op_sys());
335+
}
329336
$vars->{'rep_platform'} = detect_platform();
330337
$vars->{'rep_op_sys'} = detect_op_sys();
331338

0 commit comments

Comments
 (0)