Fix GetMerkleProof for odd numbered nodes #66
Merged
+104
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



This pull request improves the handling of Merkle proofs for trees with an odd number of leaves, ensuring correct behavior and preventing potential panics when a leaf node does not have a sibling. It also adds comprehensive tests to verify this behavior and updates dependencies.
Merkle proof logic improvements
getLeafSiblingHashfunction insubtree.goto correctly handle cases where a leaf node has no sibling by duplicating the last node's hash, following Bitcoin convention. This prevents panics when generating proofs for odd numbers of leaves.Testing enhancements
TestGetMerkleProofOddLeavesinsubtree_test.gowith multiple sub-tests to verify Merkle proof correctness for trees with odd and even numbers of leaves, including large trees. These tests ensure the new logic works as intended and prevent regressions.Dependency updates
go.modfrom 1.24.3 to 1.24.6 and bumped thegolang.org/x/expdependency to a newer version.