add specs

Author: pranavj1001

bin/helpers/utils.js

@@ -1212,6 +1212,9 @@ exports.getMajorVersion = (version) => {
 
     const matches = version.match(/^(\d+\.)?(\d+\.)?(\*|\d+)$/)
     if(matches && matches.length >= 2) {
+      if (!matches[1]) {
+        return matches[0];
+      }
       return matches[1].replace('.','');
     } else {
       return null;

test/unit/bin/helpers/packageInstaller.js

@@ -7,7 +7,8 @@ const chai = require("chai"),
   cp = require('child_process');
 
 const logger = require("../../../../bin/helpers/logger").winstonLogger,
-fileHelpers = require("../../../../bin/helpers/fileHelpers");
+fileHelpers = require("../../../../bin/helpers/fileHelpers"),
+utils = require('../../../../bin/helpers/utils');
 
 const rewire = require("rewire");
 
@@ -214,15 +215,47 @@ describe("packageInstaller", () => {
   context("packageInstall", () => {
     const packageInstaller = rewire("../../../../bin/helpers/packageInstaller");
 
-    it("should call npm install on directory and resolve if spawn is closed successfully", () => {
+    it("should call npm install on directory with npm <= 6 and resolve if spawn is closed successfully", () => {
       let spawnStub = sandbox.stub(cp, 'spawn').returns({
         on: (_close, nodeProcessCloseCallback) => {
           nodeProcessCloseCallback(0);
         }
       });
+      let getMajorVersionStub = sandbox.stub(utils, 'getMajorVersion').returns('7');
       packageInstaller.__set__({
         nodeProcess: {},
-        spawn: spawnStub
+        spawn: spawnStub,
+        utils: {
+          getMajorVersion: getMajorVersionStub
+        }
+      });
+      let packageInstallrewire = packageInstaller.__get__('packageInstall');
+      let directoryPath = "/random/path";
+      return packageInstallrewire(directoryPath)
+      .then((data) => {
+        console.log(data);
+        chai.assert.equal(data, "Packages were installed successfully.")
+        spawnStub.restore();
+        getMajorVersionStub.restore();
+      })
+      .catch((_error) => {
+        chai.assert.fail(`Promise error ${_error}`);
+      });
+    });
+
+    it("should call npm install on directory with npm >= 7 and resolve if spawn is closed successfully", () => {
+      let spawnStub = sandbox.stub(cp, 'spawn').returns({
+        on: (_close, nodeProcessCloseCallback) => {
+          nodeProcessCloseCallback(0);
+        }
+      });
+      let getMajorVersionStub = sandbox.stub(utils, 'getMajorVersion').returns('7');
+      packageInstaller.__set__({
+        nodeProcess: {},
+        spawn: spawnStub,
+        utils: {
+          getMajorVersion: getMajorVersionStub
+        }
       });
       let packageInstallrewire = packageInstaller.__get__('packageInstall');
       let directoryPath = "/random/path";
@@ -231,6 +264,7 @@ describe("packageInstaller", () => {
         console.log(data);
         chai.assert.equal(data, "Packages were installed successfully.")
         spawnStub.restore();
+        getMajorVersionStub.restore();
       })
       .catch((_error) => {
         chai.assert.fail(`Promise error ${_error}`);

test/unit/bin/helpers/utils.js

@@ -3222,4 +3222,34 @@ describe('utils', () => {
       expect(utils.formatRequest(null, {statusCode: 500}, cricularBody)).to.be.eql({err: null, status: 500, body: '[Circular]'});
     });
   });
+
+  describe('getMajorVersion', () => {
+    it('should return null if undefined version is sent', () => {
+      expect(utils.getMajorVersion()).to.be.eql(null);
+    });
+
+    it('should return null if null version is sent', () => {
+      expect(utils.getMajorVersion(null)).to.be.eql(null);
+    });
+
+    it('should return null if improper version is sent', () => {
+      expect(utils.getMajorVersion('test')).to.be.eql(null);
+      expect(utils.getMajorVersion('a1.1.1')).to.be.eql(null);
+      expect(utils.getMajorVersion('1a.1.1')).to.be.eql(null);
+      expect(utils.getMajorVersion('1.a1.1')).to.be.eql(null);
+      expect(utils.getMajorVersion('1.1a.1')).to.be.eql(null);
+      expect(utils.getMajorVersion('1.1.a1')).to.be.eql(null);
+      expect(utils.getMajorVersion('1.1.1a')).to.be.eql(null);
+      expect(utils.getMajorVersion('.1.1.1')).to.be.eql(null);
+      expect(utils.getMajorVersion('1.')).to.be.eql(null);
+      expect(utils.getMajorVersion('$')).to.be.eql(null);
+    });
+
+    it('should return proper major version if proper version is sent', () => {
+      expect(utils.getMajorVersion('1.1.1')).to.be.eql('1');
+      expect(utils.getMajorVersion('2.1')).to.be.eql('2');
+      expect(utils.getMajorVersion('3')).to.be.eql('3');
+      expect(utils.getMajorVersion('4.1')).to.be.eql('4');
+    });
+  });
 });