Merge pull request #296 from browserstack/bstack_origin/CYP-1134-add-npm-install-logs

Add some additional logs and output npm install logs

Author: nagpalkaran95

bin/helpers/packageInstaller.js

@@ -7,7 +7,8 @@
   Constants = require('./constants'),
   process = require('process'),
   utils = require('./utils'),
-  { spawn } = require('child_process');
+  { spawn } = require('child_process'),
+  util = require('util');
 
 let nodeProcess;
 
@@ -54,16 +55,18 @@ const packageInstall = (packageDir) => {
   return new Promise(function (resolve, reject) {
     const nodeProcessCloseCallback = (code) => {
       if(code == 0) {
+        logger.info(`Packages were installed locally successfully.`);
         resolve('Packages were installed successfully.');
       } else {
-        reject('Packages were not installed successfully.');
+        logger.error(`Some error occurred while installing packages. Error code ${code}`);
+        reject('Packages were not installed successfully. Error code ${code}');
       }
     };
     const nodeProcessErrorCallback = (error) => {
-      logger.error(`Some error occurred while installing packages: ${error}`);
-      reject(`Packages were not installed successfully.`);
+      logger.error(`Some error occurred while installing packages: ${util.inspect(error)}`);
+      reject(`Packages were not installed successfully. Error Description ${util.inspect(error)}`);
     };
-    nodeProcess = spawn(/^win/.test(process.platform) ? 'npm.cmd' : 'npm', ['install'], {cwd: packageDir});
+    nodeProcess = spawn(/^win/.test(process.platform) ? 'npm.cmd' : 'npm', ['install', '--loglevel', 'verbose', '>', '../npm_install_debug.log', '2>&1'], {cwd: packageDir, shell: true});
     nodeProcess.on('close', nodeProcessCloseCallback);
     nodeProcess.on('error', nodeProcessErrorCallback);
   });

test/unit/bin/helpers/packageInstaller.js

@@ -256,7 +256,7 @@ describe("packageInstaller", () => {
       })
       .catch((error) => {
         spawnStub.restore();
-        chai.assert.equal(error, "Packages were not installed successfully.")
+        chai.assert.equal(error, "Packages were not installed successfully. Error code 1")
       });
     });
   });