Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/pg-pool/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ class Pool extends EventEmitter {
return response.result
}

// allow plain text query without values
// allow plain text query without values, but callback
if (typeof values === 'function') {
cb = values
values = undefined
Expand Down
4 changes: 4 additions & 0 deletions packages/pg/lib/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,10 @@ class Client extends EventEmitter {
Error.captureStackTrace(err)
throw err
})
} else {
if (!(typeof query.callback === 'function')) {
throw new Error('callback is not a function')
}
}
}

Expand Down
12 changes: 12 additions & 0 deletions packages/pg/test/unit/client/simple-query-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,5 +140,17 @@ test('executing query', function () {
)
}
})

test('throws an error when callback is not a function', function () {
try {
client.query('SELECT $1', [1], 'notafunction')
} catch (error) {
assert.equal(
error.message,
'callback is not a function',
'Should have thrown an Error for non function callback'
)
}
})
})
})