New version breaks in cloudflare vitests: No such module "node:process"

[astanciu]

When running vitests for cloudflare workers, via vitest-pool-workers, I started getting these:

Error: No such module "node:process".
 ❯ ../../Users/user/owlie/node_modules/.pnpm/pg-connection-string@2.10.0/node_modules/pg-connection-string/index.js?mf_vitest_no_cjs_esm_shim:3:25
 ❯ ../../Users/user/owlie/node_modules/.pnpm/pg@8.17.1/node_modules/pg/lib/connection-parameters.js?mf_vitest_no_cjs_esm_shim:7:15
 ❯ ../../Users/user/owlie/node_modules/.pnpm/pg@8.17.1/node_modules/pg/lib/client.js?mf_vitest_no_cjs_esm_shim:9:30
 ❯ ../../Users/user/owlie/node_modules/.pnpm/pg@8.17.1/node_modules/pg/lib/index.js?mf_vitest_no_cjs_esm_shim:3:16

I jumped from v8.16.3 to v8.17.1 this also bumped pg-connection-string from 2.9.1 → 2.10.0
I compared local index.js between 2.9.1 and 2.10.0, and the new node:process import + SSL warning helper is the only substantive change (and it explains the failure).

[brianc]

Dang it! sorry! Will fix immediately. Hold tight....

[brianc]

Successfully published:
 - pg-connection-string@2.10.1
 - pg-cursor@2.16.2
 - pg-esm-test@1.3.2
 - pg-query-stream@4.11.2
 - pg@8.17.2

Should be good for you now! Sorry 'bout that.

[astanciu]

@brianc Thanks for the quick publish! I can confirm 2.10.1 still fails in Cloudflare Workers + vitest-pool-workers.

Local repro:

• pg@8.17.2 -> pg-connection-string@2.10.1
• test runtime: @cloudflare/vitest-pool-workers (miniflare/workerd)

pg-connection-string@2.10.1 now does:
const { emitWarning } = require('process')

But in workerd this still fails because process isn’t available (node compat doesn’t provide it in vitest-pool-workers). The resolver logs show it as node:process, and the test error is:

    Failed to require "node:process" from ".../pg-connection-string/index.js?mf_vitest_no_cjs_esm_shim"

pg-connection-string@2.9.1 works because it doesn’t import any Node builtins.

So the patch doesn’t help for Workers. Is it possible to avoid importing process at module top-level (or guard it, e.g. use globalThis.process only if defined), or move emitWarning behind a Node-only check? Or is this a better issue for cloudflare to figure out on their end?

[brianc]

ohhhhhhhh I see I see sorry I was confused because the node: thing was causing other incompatbility issues. You're right I can put it behind a check for node or cloudflare. Its been a min, I'll have to look into how to check for workerd being around again. I'm actually about to start working on a side project using workers and postgres so that will be a nice dogfooding for myself.

I wont have time to look at this more today, but can definitely check it out tomorrow & should have a fix. 😄