From eb1e5eb5cfa55b2cdd92990a6b007116e8571d08 Mon Sep 17 00:00:00 2001 From: mbmcmullen27 Date: Mon, 20 Mar 2023 10:51:19 -0500 Subject: [PATCH 1/9] cause an error --- api-server.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/api-server.js b/api-server.js index e5e2006..83dfc3e 100644 --- a/api-server.js +++ b/api-server.js @@ -31,7 +31,8 @@ app.post('/employees', function(req, res) { } res.send(employee) } else { - res.status(400).send('Missing employee name') + // res.status(400).send('Missing employee name') + res.send() } }) From 33ada3c90b1c333c9832194b120d187d7e2c7681 Mon Sep 17 00:00:00 2001 From: mbmcmullen27 Date: Mon, 20 Mar 2023 13:09:59 -0500 Subject: [PATCH 2/9] trigger on prs --- .github/workflows/newman-test.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/newman-test.yaml b/.github/workflows/newman-test.yaml index b823317..5b1a5d2 100644 --- a/.github/workflows/newman-test.yaml +++ b/.github/workflows/newman-test.yaml @@ -2,11 +2,13 @@ name: Test api on: workflow_dispatch: + pull_request: + types: [opened, edited] env: GH_TOKEN: ${{ github.token }} jobs: test: - uses: boxboat-github-practice/reusable-workflows/.github/workflows/simple-tracker-test.yaml@d6ad89cb51d6f1a6982bb441f0523a403549c056 + uses: boxboat-github-practice/reusable-workflows/.github/workflows/simple-tracker-test.yaml@main \ No newline at end of file From 3500f73051b1e683895c50bfd16099e390cc0b34 Mon Sep 17 00:00:00 2001 From: mbmcmullen27 Date: Mon, 20 Mar 2023 13:32:30 -0500 Subject: [PATCH 3/9] small change --- api-server.js | 1 + 1 file changed, 1 insertion(+) diff --git a/api-server.js b/api-server.js index 83dfc3e..b179dc3 100644 --- a/api-server.js +++ b/api-server.js @@ -32,6 +32,7 @@ app.post('/employees', function(req, res) { res.send(employee) } else { // res.status(400).send('Missing employee name') + res.send() } }) From eeb2526d155565b0a0d3d140ca563aa980f73fb7 Mon Sep 17 00:00:00 2001 From: mbmcmullen27 Date: Mon, 20 Mar 2023 15:20:41 -0500 Subject: [PATCH 4/9] change names --- .github/workflows/newman-test.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/newman-test.yaml b/.github/workflows/newman-test.yaml index 5b1a5d2..1a4f4e1 100644 --- a/.github/workflows/newman-test.yaml +++ b/.github/workflows/newman-test.yaml @@ -1,4 +1,4 @@ -name: Test api +name: Smoke Test on: workflow_dispatch: @@ -9,6 +9,6 @@ env: GH_TOKEN: ${{ github.token }} jobs: - test: + newman: uses: boxboat-github-practice/reusable-workflows/.github/workflows/simple-tracker-test.yaml@main \ No newline at end of file From bf2f4bff89b982ac15dd43db76718fd6eabfc260 Mon Sep 17 00:00:00 2001 From: mbmcmullen27 Date: Mon, 20 Mar 2023 15:25:10 -0500 Subject: [PATCH 5/9] trigger on all pull request events --- .github/workflows/newman-test.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/newman-test.yaml b/.github/workflows/newman-test.yaml index 1a4f4e1..89242cb 100644 --- a/.github/workflows/newman-test.yaml +++ b/.github/workflows/newman-test.yaml @@ -3,7 +3,6 @@ name: Smoke Test on: workflow_dispatch: pull_request: - types: [opened, edited] env: GH_TOKEN: ${{ github.token }} From 0dff856a067068cb8cf1a1111e6a15a3db9d0287 Mon Sep 17 00:00:00 2001 From: mbmcmullen27 Date: Mon, 20 Mar 2023 15:41:39 -0500 Subject: [PATCH 6/9] more space --- api-server.js | 1 + 1 file changed, 1 insertion(+) diff --git a/api-server.js b/api-server.js index b179dc3..853d279 100644 --- a/api-server.js +++ b/api-server.js @@ -33,6 +33,7 @@ app.post('/employees', function(req, res) { } else { // res.status(400).send('Missing employee name') + res.send() } }) From 6d31bf975c545f544638671c6c22f7e46f89d651 Mon Sep 17 00:00:00 2001 From: mbmcmullen27 Date: Mon, 20 Mar 2023 15:45:11 -0500 Subject: [PATCH 7/9] different error --- api-server.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/api-server.js b/api-server.js index 853d279..206eeae 100644 --- a/api-server.js +++ b/api-server.js @@ -31,10 +31,7 @@ app.post('/employees', function(req, res) { } res.send(employee) } else { - // res.status(400).send('Missing employee name') - - - res.send() + res.status(400).send('Missing employee name') } }) @@ -51,7 +48,7 @@ app.put('/employees/:id', function(req, res) { res.status(404) res.send("Employee not found") } else if (req.body.id !== undefined) { - res.status(400) + // res.status(400) res.send("Cannot update primary id") } else { console.log(`User ${employee.id} updated:`) From 6b2874fcbf65eca7ee5a791c2c17e8f8ca9c0358 Mon Sep 17 00:00:00 2001 From: mbmcmullen27 Date: Mon, 20 Mar 2023 15:47:13 -0500 Subject: [PATCH 8/9] remove errors --- api-server.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api-server.js b/api-server.js index 206eeae..e5e2006 100644 --- a/api-server.js +++ b/api-server.js @@ -48,7 +48,7 @@ app.put('/employees/:id', function(req, res) { res.status(404) res.send("Employee not found") } else if (req.body.id !== undefined) { - // res.status(400) + res.status(400) res.send("Cannot update primary id") } else { console.log(`User ${employee.id} updated:`) From 4a54f5c69c9413abf62a9dce33c35a9057c606b5 Mon Sep 17 00:00:00 2001 From: mbmcmullen27 Date: Tue, 21 Mar 2023 16:12:31 -0500 Subject: [PATCH 9/9] force error --- api-server.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/api-server.js b/api-server.js index e5e2006..83dfc3e 100644 --- a/api-server.js +++ b/api-server.js @@ -31,7 +31,8 @@ app.post('/employees', function(req, res) { } res.send(employee) } else { - res.status(400).send('Missing employee name') + // res.status(400).send('Missing employee name') + res.send() } })