#9 - Created private methods for the static factories and fixed a couple other linting problems.

Author: laxika

java-warc/src/main/java/com/github/bottomlessarchive/warc/service/AvailableInputStream.java

@@ -19,18 +19,22 @@ public int read() throws IOException {
         return inputStream.read();
     }
 
+    @Override
     public int read(byte[] b) throws IOException {
         return inputStream.read(b);
     }
 
+    @Override
     public int read(byte[] b, int off, int len) throws IOException {
         return inputStream.read(b, off, len);
     }
 
+    @Override
     public void close() throws IOException {
         inputStream.close();
     }
 
+    @Override
     public int available() throws IOException {
         // Always say that we have 1 more byte in the
         // buffer, even when we don't

java-warc/src/main/java/com/github/bottomlessarchive/warc/service/WarcRecordIteratorFactory.java

@@ -17,6 +17,9 @@ public class WarcRecordIteratorFactory {
 
     private static final int ONE_MEGABYTE_IN_BYTE = 1048576;
 
+    private WarcRecordIteratorFactory() {
+    }
+
     public static <T extends WarcContentBlock> Iterator<WarcRecord<T>> iteratorOf(final URI uri) {
         try {
             return iteratorOf(uri.toURL());

java-warc/src/main/java/com/github/bottomlessarchive/warc/service/WarcRecordStreamFactory.java

@@ -22,6 +22,9 @@ public class WarcRecordStreamFactory {
 
     private static final List<WarcRecordType> EVERY_WARC_RECORD_TYPE = Arrays.asList(WarcRecordType.values());
 
+    private WarcRecordStreamFactory() {
+    }
+
     public static <T extends WarcContentBlock> Stream<WarcRecord<T>> streamOf(@NotNull @NonNull final URI uri) {
         try {
             return WarcRecordStreamFactory.streamOf(uri.toURL(), EVERY_WARC_RECORD_TYPE);

java-warc/src/main/java/com/github/bottomlessarchive/warc/service/content/response/domain/ResponseContentBlock.java

@@ -84,10 +84,10 @@ public Optional<Charset> getCharset() {
      * @return the payload of the content block as string
      */
     public String getPayloadAsString() {
-        final Charset charset = this.charset != null ? this.charset : WarcReader.DEFAULT_CHARSET;
+        final Charset payloadCharset = this.charset != null ? this.charset : WarcReader.DEFAULT_CHARSET;
 
         try {
-            return IOUtils.toString(payload, charset);
+            return IOUtils.toString(payload, payloadCharset);
         } catch (IOException e) {
             throw new WarcParsingException("Unable to parse the payload of a WARC document!", e);
         }

java-warc/src/main/java/com/github/bottomlessarchive/warc/service/http/HttpParser.java

@@ -5,13 +5,17 @@
 import java.io.InputStream;
 import java.nio.charset.Charset;
 import java.util.ArrayList;
+
 import org.apache.http.Header;
 import org.apache.http.HttpException;
 import org.apache.http.ProtocolException;
 import org.apache.http.message.BasicHeader;
 
 public class HttpParser {
 
+    private HttpParser() {
+    }
+
     /**
      * Read up to "\n" from an (unchunked) input stream. If the stream ends before the line terminator
      * is found, the last part of the string will still be returned. If no input data available,
@@ -80,10 +84,10 @@ public static byte[] readRawLine(InputStream inputStream) throws IOException {
      * @throws HttpException if there is an error parsing a header value
      */
     public static Header[] parseHeaders(InputStream is, Charset charset)
-        throws IOException, HttpException {
+            throws IOException, HttpException {
         ArrayList<Header> headers = new ArrayList<>();
         String name = null;
-        StringBuffer value = null;
+        StringBuilder value = null;
         for (; ; ) {
             String line = readLine(is, charset);
             if ((line == null) || (line.trim().length() < 1)) {
@@ -114,7 +118,7 @@ public static Header[] parseHeaders(InputStream is, Charset charset)
                     throw new ProtocolException("Unable to parse header: " + line);
                 }
                 name = line.substring(0, colon).trim();
-                value = new StringBuffer(line.substring(colon + 1).trim());
+                value = new StringBuilder(line.substring(colon + 1).trim());
             }
 
         }