Skip to content

Commit a2d9f11

Browse files
Merge pull request #70 from hhslepicka/expand-ci
CI: Expand matrix to include Windows and macOS.
2 parents 0fc7aec + 04ff863 commit a2d9f11

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

.github/workflows/ci.yml

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,30 @@ env:
1313
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
1414

1515
jobs:
16-
build:
16+
test:
1717
runs-on: ${{ matrix.os }}
1818
defaults:
1919
run:
2020
shell: bash
2121
strategy:
22+
# Don't abort if a matrix combination fails
23+
fail-fast: false
2224
matrix:
23-
os: [ubuntu-latest]
25+
os: [ubuntu-latest, windows-latest, macos-latest]
2426
python-version: ["3.10"]
25-
browser: [firefox, chrome, edge]
27+
browser: ["firefox", "chrome", "edge"]
2628
headless: [true]
27-
29+
exclude:
30+
# Can't install firefox using setup-firefox on Windows
31+
# See the issues below
32+
# * https://github.com/browser-actions/setup-firefox/issues/252
33+
# * https://github.com/abhi1693/setup-browser/issues/8
34+
- os: windows-latest
35+
browser: "firefox"
2836
steps:
2937
- uses: actions/checkout@v2
3038
- name: Install libgl1
39+
if: runner.os == 'Linux'
3140
run: |
3241
sudo dpkg --add-architecture i386
3342
sudo apt update
@@ -47,15 +56,15 @@ jobs:
4756
pip install .
4857
4958
- uses: browser-actions/setup-chrome@latest
50-
if: ${{ matrix.browser }} == "chrome"
59+
if: matrix.browser == 'chrome'
5160
with:
5261
chrome-version: stable
5362

5463
- uses: browser-actions/setup-firefox@latest
55-
if: ${{ matrix.browser }} == "firefox"
64+
if: matrix.browser == 'firefox'
5665

5766
- uses: browser-actions/setup-edge@latest
58-
if: ${{ matrix.browser }} == "edge"
67+
if: matrix.browser == 'edge'
5968

6069
- name: Run Tests in ${{ matrix.browser }}
6170
run: |

0 commit comments

Comments
 (0)