chore: upgrade vitest, tweak knip (#299)

43081j · web-flow · commit 127b3429b783 · 2025-04-18T10:42:23.000+01:00
diff --git a/.config/knip.json b/.config/knip.json
diff --git a/examples/basic/package.json b/examples/basic/package.json
@@ -4,9 +4,9 @@
   "version": "0.0.0",
   "type": "module",
   "dependencies": {
-    "@clack/core": "workspace:*",
     "@clack/prompts": "workspace:*",
-    "picocolors": "^1.0.0"
+    "picocolors": "^1.0.0",
+    "jiti": "^1.17.0"
   },
   "scripts": {
     "start": "jiti ./index.ts",
@@ -17,6 +17,6 @@
     "spinner-timer": "jiti ./spinner-timer.ts"
   },
   "devDependencies": {
-    "jiti": "^1.17.0"
+    "cross-env": "^7.0.3"
   }
 }
diff --git a/examples/changesets/package.json b/examples/changesets/package.json
@@ -4,14 +4,12 @@
   "version": "0.0.0",
   "type": "module",
   "dependencies": {
-    "@clack/core": "workspace:*",
+    "jiti": "^1.17.0",
     "@clack/prompts": "workspace:*",
     "picocolors": "^1.0.0"
   },
   "scripts": {
     "start": "jiti ./index.ts"
   },
-  "devDependencies": {
-    "jiti": "^1.17.0"
-  }
+  "devDependencies": {}
 }
diff --git a/knip.json b/knip.json
@@ -0,0 +1,15 @@
+{
+  "workspaces": {
+    ".": {
+      "ignore": ["build.preset.ts"]
+    },
+    "examples/*": {
+      "entry": "*.ts!",
+      "project": "*.ts"
+    },
+    "packages/*": {
+      "entry": "src/index.ts!",
+      "project": ["src/**/*.ts!", "test/**/*.ts"]
+    }
+  }
+}
diff --git a/package.json b/package.json
@@ -12,20 +12,21 @@
     "type-check": "biome lint && tsc",
     "test": "pnpm --color -r run test",
     "ci:install": "pnpm install --no-frozen-lockfile",
-    "ci:version": "changeset version && pnpm add -D @pnpm/logger@^5.1.0 @pnpm/worker@^1000.1.3 && pnpx @qingshaner/jsr-release --allowDirty version --sync",
+    "ci:version": "changeset version && pnpx @qingshaner/jsr-release --allowDirty version --sync",
     "ci:publish": "changeset publish",
     "ci:prepublish": "pnpm build",
-    "deps:check": "pnpm dlx knip --production",
+    "deps:check": "pnpm exec knip --production",
     "jsr:test": "pnpm --filter \"@clack/*\" jsr --dry-run",
     "jsr:run": "pnpm --filter \"@clack/*\" jsr"
   },
   "devDependencies": {
     "@biomejs/biome": "1.9.4",
     "@changesets/cli": "^2.26.2",
     "@types/node": "^18.16.0",
-    "knip": "^3.8.4",
+    "knip": "^5.50.4",
     "typescript": "^5.8.3",
-    "unbuild": "^2.0.0"
+    "unbuild": "^2.0.0",
+    "jsr": "^0.13.4"
   },
   "packageManager": "pnpm@9.14.2",
   "volta": {
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -54,7 +54,7 @@
     "sisteransi": "^1.0.5"
   },
   "devDependencies": {
-    "vitest": "^1.6.0",
+    "vitest": "^3.1.1",
     "wrap-ansi": "^8.1.0"
   }
 }
diff --git a/packages/core/src/prompts/text.ts b/packages/core/src/prompts/text.ts
@@ -1,7 +1,7 @@
 import color from 'picocolors';
 import Prompt, { type PromptOptions } from './prompt.js';
 
-export interface TextOptions extends PromptOptions<TextPrompt> {
+interface TextOptions extends PromptOptions<TextPrompt> {
 	placeholder?: string;
 	defaultValue?: string;
 }
diff --git a/packages/core/src/utils/index.ts b/packages/core/src/utils/index.ts
@@ -23,7 +23,7 @@ export function setRawMode(input: Readable, value: boolean) {
 	if (i.isTTY) i.setRawMode(value);
 }
 
-export interface BlockOptions {
+interface BlockOptions {
 	input?: Readable;
 	output?: Writable;
 	overwrite?: boolean;
diff --git a/packages/prompts/package.json b/packages/prompts/package.json
@@ -47,7 +47,7 @@
   "scripts": {
     "build": "unbuild",
     "prepack": "pnpm build",
-    "test": "vitest run"
+    "test": "FORCE_COLOR=1 vitest run"
   },
   "dependencies": {
     "@clack/core": "workspace:*",
@@ -56,6 +56,6 @@
   },
   "devDependencies": {
     "is-unicode-supported": "^1.3.0",
-    "vitest": "^1.6.0"
+    "vitest": "^3.1.1"
   }
 }
diff --git a/packages/prompts/test/__snapshots__/progress-bar.test.ts.snap b/packages/prompts/test/__snapshots__/progress-bar.test.ts.snap
@@ -12,7 +12,7 @@ exports[`prompts - progress (isCI = false) > message > sets message for next fra
 ]
 `;
 
-exports[`prompts - progress (isCI = false) > process exit handling > prioritizes direct options over global settings 1`] = `
+exports[`prompts - progress (isCI = false) > process exit handling > prioritizes cancel option over global setting 1`] = `
 [
   "[?25l",
   "[90m│[39m
@@ -23,7 +23,7 @@ exports[`prompts - progress (isCI = false) > process exit handling > prioritizes
 ]
 `;
 
-exports[`prompts - progress (isCI = false) > process exit handling > prioritizes direct options over global settings 2`] = `
+exports[`prompts - progress (isCI = false) > process exit handling > prioritizes error option over global setting 1`] = `
 [
   "[?25l",
   "[90m│[39m
@@ -278,7 +278,7 @@ exports[`prompts - progress (isCI = true) > message > sets message for next fram
 ]
 `;
 
-exports[`prompts - progress (isCI = true) > process exit handling > prioritizes direct options over global settings 1`] = `
+exports[`prompts - progress (isCI = true) > process exit handling > prioritizes cancel option over global setting 1`] = `
 [
   "[?25l",
   "[90m│[39m
@@ -289,7 +289,7 @@ exports[`prompts - progress (isCI = true) > process exit handling > prioritizes
 ]
 `;
 
-exports[`prompts - progress (isCI = true) > process exit handling > prioritizes direct options over global settings 2`] = `
+exports[`prompts - progress (isCI = true) > process exit handling > prioritizes error option over global setting 1`] = `
 [
   "[?25l",
   "[90m│[39m
diff --git a/packages/prompts/test/__snapshots__/spinner.test.ts.snap b/packages/prompts/test/__snapshots__/spinner.test.ts.snap
@@ -12,7 +12,7 @@ exports[`spinner (isCI = false) > message > sets message for next frame 1`] = `
 ]
 `;
 
-exports[`spinner (isCI = false) > process exit handling > prioritizes direct options over global settings 1`] = `
+exports[`spinner (isCI = false) > process exit handling > prioritizes cancel option over global setting 1`] = `
 [
   "[?25l",
   "[90m│[39m
@@ -23,7 +23,7 @@ exports[`spinner (isCI = false) > process exit handling > prioritizes direct opt
 ]
 `;
 
-exports[`spinner (isCI = false) > process exit handling > prioritizes direct options over global settings 2`] = `
+exports[`spinner (isCI = false) > process exit handling > prioritizes error option over global setting 1`] = `
 [
   "[?25l",
   "[90m│[39m
@@ -209,7 +209,7 @@ exports[`spinner (isCI = true) > message > sets message for next frame 1`] = `
 ]
 `;
 
-exports[`spinner (isCI = true) > process exit handling > prioritizes direct options over global settings 1`] = `
+exports[`spinner (isCI = true) > process exit handling > prioritizes cancel option over global setting 1`] = `
 [
   "[?25l",
   "[90m│[39m
@@ -220,7 +220,7 @@ exports[`spinner (isCI = true) > process exit handling > prioritizes direct opti
 ]
 `;
 
-exports[`spinner (isCI = true) > process exit handling > prioritizes direct options over global settings 2`] = `
+exports[`spinner (isCI = true) > process exit handling > prioritizes error option over global setting 1`] = `
 [
   "[?25l",
   "[90m│[39m
diff --git a/packages/prompts/test/progress-bar.test.ts b/packages/prompts/test/progress-bar.test.ts
@@ -209,72 +209,83 @@ describe.each(['true', 'false'])('prompts - progress (isCI = %s)', (isCI) => {
 		test('uses global custom cancel message from settings', () => {
 			// Store original message
 			const originalCancelMessage = prompts.settings.messages.cancel;
-			// Set custom message
-			prompts.settings.messages.cancel = 'Global cancel message';
+			try {
+				// Set custom message
+				prompts.settings.messages.cancel = 'Global cancel message';
 
-			const result = prompts.progress({ output });
-			result.start('Test operation');
-
-			processEmitter.emit('SIGINT');
+				const result = prompts.progress({ output });
+				result.start('Test operation');
 
-			expect(output.buffer).toMatchSnapshot();
+				processEmitter.emit('SIGINT');
 
-			// Reset to original
-			prompts.settings.messages.cancel = originalCancelMessage;
+				expect(output.buffer).toMatchSnapshot();
+			} finally {
+				// Reset to original
+				prompts.settings.messages.cancel = originalCancelMessage;
+			}
 		});
 
 		test('uses global custom error message from settings', () => {
 			// Store original message
 			const originalErrorMessage = prompts.settings.messages.error;
-			// Set custom message
-			prompts.settings.messages.error = 'Global error message';
-
-			const result = prompts.progress({ output });
-			result.start('Test operation');
+			try {
+				// Set custom message
+				prompts.settings.messages.error = 'Global error message';
 
-			processEmitter.emit('exit', 2);
+				const result = prompts.progress({ output });
+				result.start('Test operation');
 
-			expect(output.buffer).toMatchSnapshot();
+				processEmitter.emit('exit', 2);
 
-			// Reset to original
-			prompts.settings.messages.error = originalErrorMessage;
+				expect(output.buffer).toMatchSnapshot();
+			} finally {
+				// Reset to original
+				prompts.settings.messages.error = originalErrorMessage;
+			}
 		});
 
-		test('prioritizes direct options over global settings', () => {
+		test('prioritizes error option over global setting', () => {
 			// Store original messages
-			const originalCancelMessage = prompts.settings.messages.cancel;
 			const originalErrorMessage = prompts.settings.messages.error;
 
-			// Set custom global messages
-			prompts.settings.messages.cancel = 'Global cancel message';
-			prompts.settings.messages.error = 'Global error message';
+			try {
+				// Set custom global messages
+				prompts.settings.messages.error = 'Global error message';
 
-			const result = prompts.progress({
-				output,
-				cancelMessage: 'Progress cancel message',
-				errorMessage: 'Progress error message',
-			});
-			result.start('Test operation');
+				const result = prompts.progress({
+					output,
+					errorMessage: 'Progress error message',
+				});
+				result.start('Test operation');
 
-			processEmitter.emit('SIGINT');
-			expect(output.buffer).toMatchSnapshot();
+				processEmitter.emit('exit', 2);
+				expect(output.buffer).toMatchSnapshot();
+			} finally {
+				// Reset to original values
+				prompts.settings.messages.error = originalErrorMessage;
+			}
+		});
 
-			// Reset buffer
-			output.buffer = [];
+		test('prioritizes cancel option over global setting', () => {
+			// Store original messages
+			const originalCancelMessage = prompts.settings.messages.cancel;
 
-			const result2 = prompts.progress({
-				output,
-				cancelMessage: 'Progress cancel message',
-				errorMessage: 'Progress error message',
-			});
-			result2.start('Test operation');
+			try {
+				// Set custom global messages
+				prompts.settings.messages.cancel = 'Global cancel message';
 
-			processEmitter.emit('exit', 2);
-			expect(output.buffer).toMatchSnapshot();
+				const result = prompts.progress({
+					output,
+					cancelMessage: 'Progress cancel message',
+				});
+				result.start('Test operation');
 
-			// Reset to original values
-			prompts.settings.messages.cancel = originalCancelMessage;
-			prompts.settings.messages.error = originalErrorMessage;
+				processEmitter.emit('SIGINT');
+				expect(output.buffer).toMatchSnapshot();
+			} finally {
+				// Reset to original values
+				prompts.settings.messages.cancel = originalCancelMessage;
+			}
 		});
 	});
 
diff --git a/packages/prompts/test/spinner.test.ts b/packages/prompts/test/spinner.test.ts
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@`
`54`	`54`	`"sisteransi": "^1.0.5"`
`55`	`55`	`},`
`56`	`56`	`"devDependencies": {`
`57`		`- "vitest": "^1.6.0",`
	`57`	`+ "vitest": "^3.1.1",`
`58`	`58`	`"wrap-ansi": "^8.1.0"`
`59`	`59`	`}`
`60`	`60`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`import color from 'picocolors';`
`2`	`2`	`import Prompt, { type PromptOptions } from './prompt.js';`
`3`	`3`
`4`		`-export interface TextOptions extends PromptOptions<TextPrompt> {`
	`4`	`+interface TextOptions extends PromptOptions<TextPrompt> {`
`5`	`5`	`placeholder?: string;`
`6`	`6`	`defaultValue?: string;`
`7`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ export function setRawMode(input: Readable, value: boolean) {`
`23`	`23`	`if (i.isTTY) i.setRawMode(value);`
`24`	`24`	`}`
`25`	`25`
`26`		`-export interface BlockOptions {`
	`26`	`+interface BlockOptions {`
`27`	`27`	`input?: Readable;`
`28`	`28`	`output?: Writable;`
`29`	`29`	`overwrite?: boolean;`
Original file line number	Diff line number	Diff line change
@@ -12,7 +12,7 @@ exports[`prompts - progress (isCI = false) > message > sets message for next fra
`12`	`12`	`]`
`13`	`13`	`;
`14`	`14`
`15`		-exports[`prompts - progress (isCI = false) > process exit handling > prioritizes direct options over global settings 1`] = `
	`15`	+exports[`prompts - progress (isCI = false) > process exit handling > prioritizes cancel option over global setting 1`] = `
`16`	`16`	`[`
`17`	`17`	`"[?25l",`
`18`	`18`	`"[90m│[39m`
@@ -23,7 +23,7 @@ exports[`prompts - progress (isCI = false) > process exit handling > prioritizes
`23`	`23`	`]`
`24`	`24`	`;
`25`	`25`
`26`		-exports[`prompts - progress (isCI = false) > process exit handling > prioritizes direct options over global settings 2`] = `
	`26`	+exports[`prompts - progress (isCI = false) > process exit handling > prioritizes error option over global setting 1`] = `
`27`	`27`	`[`
`28`	`28`	`"[?25l",`
`29`	`29`	`"[90m│[39m`
@@ -278,7 +278,7 @@ exports[`prompts - progress (isCI = true) > message > sets message for next fram
`278`	`278`	`]`
`279`	`279`	`;
`280`	`280`
`281`		-exports[`prompts - progress (isCI = true) > process exit handling > prioritizes direct options over global settings 1`] = `
	`281`	+exports[`prompts - progress (isCI = true) > process exit handling > prioritizes cancel option over global setting 1`] = `
`282`	`282`	`[`
`283`	`283`	`"[?25l",`
`284`	`284`	`"[90m│[39m`
@@ -289,7 +289,7 @@ exports[`prompts - progress (isCI = true) > process exit handling > prioritizes
`289`	`289`	`]`
`290`	`290`	`;
`291`	`291`
`292`		-exports[`prompts - progress (isCI = true) > process exit handling > prioritizes direct options over global settings 2`] = `
	`292`	+exports[`prompts - progress (isCI = true) > process exit handling > prioritizes error option over global setting 1`] = `
`293`	`293`	`[`
`294`	`294`	`"[?25l",`
`295`	`295`	`"[90m│[39m`