Skip to content

Commit 718b910

Browse files
committed
prevent hitting enter to submit a form
1 parent f0c2e4a commit 718b910

File tree

7 files changed

+34
-3
lines changed

7 files changed

+34
-3
lines changed

dist/index.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -712,6 +712,11 @@
712712
}
713713

714714
function keydownHandler(ev) {
715+
// prevent submitting if the number spinner is inside a form element
716+
if (ev.key == "Enter") {
717+
ev.preventDefault();
718+
}
719+
715720
if (ev.target == dragElement || ev.target == editElement) {
716721
dispatch("consoleLog", ev.type);
717722
} // console.log(ev);

dist/index.mjs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -706,6 +706,11 @@ function instance($$self, $$props, $$invalidate) {
706706
}
707707

708708
function keydownHandler(ev) {
709+
// prevent submitting if the number spinner is inside a form element
710+
if (ev.key == "Enter") {
711+
ev.preventDefault();
712+
}
713+
709714
if (ev.target == dragElement || ev.target == editElement) {
710715
dispatch("consoleLog", ev.type);
711716
} // console.log(ev);

example/public/build/bundle.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/public/build/bundle.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/src/App.svelte

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
let value9 = 100;
1818
let value10 = 12 * 60;
1919
let value11 = 1;
20+
let value12 = 100;
2021
2122
// Callback functions for example 9 ---------------------
2223
function addDollar(val) {
@@ -233,6 +234,21 @@
233234

234235
<hr />
235236

237+
<div class="row">
238+
<div class="explanation">
239+
Hitting enter should not submit the form.<br />Current value is {value12}
240+
</div>
241+
<div class="right">
242+
<form>
243+
<div>
244+
<NumberSpinner bind:value={value12} />
245+
</div>
246+
<div>
247+
<button on:click|preventDefault={() => alert('Form was submitted')}>Submit</button>
248+
</div>
249+
</form>
250+
</div>
251+
</div>
236252

237253
</main>
238254

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
"src",
3131
"dist"
3232
],
33-
"version": "0.7.7",
33+
"version": "0.7.8",
3434
"repository": {
3535
"type": "git",
3636
"url": "git+https://github.com/bohnacker/svelte-number-spinner.git"

src/NumberSpinner.svelte

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,11 @@
180180
}
181181
182182
function keydownHandler(ev) {
183+
// prevent submitting if the number spinner is inside a form element
184+
if (ev.key == "Enter") {
185+
ev.preventDefault();
186+
}
187+
183188
if (ev.target == dragElement || ev.target == editElement) {
184189
dispatch("consoleLog", ev.type);
185190
// console.log(ev);

0 commit comments

Comments
 (0)