root logger to use custom formatter fix #50

Author: Bob Bui

CHANGELOG.md

@@ -4,7 +4,10 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).  
 The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
-## 1.2.0 - 2020-07-14
+## 1.2.2 - 2020-07-14
+ - fix #50
+ 
+## 1.2.1 - 2020-07-14
  - fix #49
 
 ## 1.2.0 - 2020-04-10

json_logging/__init__.py

@@ -29,6 +29,7 @@
 _current_framework = None
 _logger = get_library_logger(__name__)
 _request_util = None
+_default_formatter = None
 
 
 def get_correlation_id(request=None):
@@ -79,13 +80,16 @@ def config_root_logger():
         & remove duplicate handlers for request instrumentation logging.
         Please made sure that you call this after you called "logging.basicConfig() or logging.getLogger('root')
     """
+    global _default_formatter
+
     if ENABLE_JSON_LOGGING:
         ENABLE_JSON_LOGGING_DEBUG and _logger.debug("Update root logger to using JSONLogFormatter")
+
         if len(logging.root.handlers) > 0:
             if _current_framework is None or _current_framework == '-':
-                util.update_formatter_for_loggers([logging.root], JSONLogFormatter)
+                util.update_formatter_for_loggers([logging.root], _default_formatter)
             else:
-                util.update_formatter_for_loggers([logging.root], JSONLogWebFormatter)
+                util.update_formatter_for_loggers([logging.root], _default_formatter)
                 # remove all handlers for request logging
                 request_logger = _current_framework['app_request_instrumentation_configurator']().get_request_logger()
                 if request_logger:
@@ -114,6 +118,7 @@ def __init(framework_name=None, custom_formatter=None, enable_json=False):
 
     global _current_framework
     global ENABLE_JSON_LOGGING
+    global _default_formatter
     if _current_framework is not None:
         raise RuntimeError("Can not call init more than once")
 
@@ -136,22 +141,22 @@ def __init(framework_name=None, custom_formatter=None, enable_json=False):
         if ENABLE_JSON_LOGGING and _current_framework['app_configurator'] is not None:
             _current_framework['app_configurator']().config()
 
-        formatter = custom_formatter if custom_formatter else JSONLogWebFormatter
+        _default_formatter = custom_formatter if custom_formatter else JSONLogWebFormatter
     else:
-        formatter = custom_formatter if custom_formatter else JSONLogFormatter
+        _default_formatter = custom_formatter if custom_formatter else JSONLogFormatter
 
     if not enable_json and not ENABLE_JSON_LOGGING:
         _logger.warning(
             "JSON format is not enable, normal log will be in plain text but request logging still in JSON format! "
             "To enable set ENABLE_JSON_LOGGING env var to either one of following values: ['true', '1', 'y', 'yes']")
     else:
         ENABLE_JSON_LOGGING = True
-        logging._defaultFormatter = formatter()
+        logging._defaultFormatter = _default_formatter()
 
     # go to all the initialized logger and update it to use JSON formatter
     ENABLE_JSON_LOGGING_DEBUG and _logger.debug("Update all existing logger to using JSONLogFormatter")
     existing_loggers = list(map(logging.getLogger, logging.Logger.manager.loggerDict))
-    util.update_formatter_for_loggers(existing_loggers, formatter)
+    util.update_formatter_for_loggers(existing_loggers, _default_formatter)
 
 
 def init_request_instrument(app=None, custom_formatter=None):

setup.py

@@ -12,7 +12,7 @@
 
 setup(
     name="json-logging",
-    version='1.2.1',
+    version='1.2.2',
     packages=find_packages(exclude=['contrib', 'docs', 'tests*', 'example', 'dist', 'build']),
     license='Apache License 2.0',
     description="JSON Python Logging",