Fix condition for checking root logger handlers #53

Author: Bob Bui

CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).  
 The format is based on [Keep a Changelog](http://keepachangelog.com/).
 
+## 1.2.6 - 2020-08-05
+ - Fix condition for checking root logger handlers #53
+
 ## 1.2.5 - 2020-08-04
  - fix #44
 

json_logging/__init__.py

@@ -31,6 +31,7 @@
 _request_util = None
 _default_formatter = None
 
+
 def get_correlation_id(request=None):
     """
     Get current request correlation-id. If one is not present, a new one might be generated
@@ -79,16 +80,17 @@ def config_root_logger():
         & remove duplicate handlers for request instrumentation logging.
         Please made sure that you call this after you called "logging.basicConfig() or logging.getLogger('root')
     """
-    global _default_formatter
 
     if not logging.root.handlers:
         _logger.error(
             "No logging handlers found for root logger. Please made sure that you call this after you called "
             "logging.basicConfig() or logging.getLogger('root')")
+        return
 
     if ENABLE_JSON_LOGGING:
         ENABLE_JSON_LOGGING_DEBUG and _logger.debug("Update root logger to using JSONLogFormatter")
 
+        global _default_formatter
         util.update_formatter_for_loggers([logging.root], _default_formatter)
 
 

setup.py

@@ -12,7 +12,7 @@
 
 setup(
     name="json-logging",
-    version='1.2.5',
+    version='1.2.6',
     packages=find_packages(exclude=['contrib', 'docs', 'tests*', 'example', 'dist', 'build']),
     license='Apache License 2.0',
     description="JSON Python Logging",