Incorporated Gemini code review suggestions

mavwolverine · mavwolverine · commit 84763e842a70 · 2025-07-20T07:47:06.000-07:00
diff --git a/setup.py b/setup.py
@@ -3,12 +3,8 @@
 
 from setuptools import setup, find_packages
 
-version_info_major = sys.version_info[0]
-if version_info_major == 3:
-    long_description = open('README.rst', encoding="utf8").read()
-else:
-    io_open = open('README.rst', encoding="utf8")
-    long_description = io_open.read()
+with open('README.rst', encoding="utf8") as f:
+    long_description = f.read()
 
 setup(
     name="json-logging",
diff --git a/tests/helpers/constants.py b/tests/helpers/constants.py
@@ -15,7 +15,7 @@
     "correlation_id",
 ]
 
-if sys.version_info.major == 3 and sys.version_info.minor >= 12:
+if sys.version_info >= (3, 12):
     _msg_attrs.append("taskName")
 
 STANDARD_MSG_ATTRIBUTES = set(_msg_attrs)

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`"correlation_id",`
`16`	`16`	`]`
`17`	`17`
`18`		`-if sys.version_info.major == 3 and sys.version_info.minor >= 12:`
	`18`	`+if sys.version_info >= (3, 12):`
`19`	`19`	`_msg_attrs.append("taskName")`
`20`	`20`
`21`	`21`	`STANDARD_MSG_ATTRIBUTES = set(_msg_attrs)`