fix(healthcheck): pgrep is not available

[wolf31o2]

Summary by cubic

Updated Docker HEALTHCHECK to use grep on /proc/1/cmdline instead of pgrep, since pgrep isn’t available in the image. Ensures the container reports healthy when OpenVPN is running.

^{Written for commit 7f401f6. Summary will update automatically on new commits.}

Summary by CodeRabbit

• Chores
  • Enhanced container health monitoring mechanism for improved reliability and operational stability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The HEALTHCHECK instruction in the Dockerfile was modified to change the container health verification method. The check was replaced from using pgrep -f openvpn (searching for running processes) to grep -q openvpn /proc/1/cmdline (directly checking the init process's command line). This single-line change alters how the container determines if the OpenVPN service is active.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Specific areas requiring attention:
  • Verify that grep -q openvpn /proc/1/cmdline correctly identifies the OpenVPN process in /proc/1 (the init process of the container)
  • Confirm the new method provides equivalent or improved reliability compared to the previous pgrep -f approach
  • Ensure the change doesn't affect container health checks in edge cases or different container configurations

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: replacing pgrep with an alternative method in the healthcheck due to pgrep unavailability.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/default-health-check

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a35bbee and 7f401f6.

📒 Files selected for processing (1)

• Dockerfile (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: cubic · AI code reviewer

🔇 Additional comments (1)

Dockerfile (1)

15-15: The original review comment is incorrect — the healthcheck change is technically sound.

The analysis misunderstood how the entrypoint works. The script uses exec openvpn ... at the end, which replaces the shell process entirely. This means PID 1 becomes the openvpn process itself, not the entrypoint script. Therefore, /proc/1/cmdline will contain the openvpn command line and will match the "openvpn" string.

The new healthcheck is functionally equivalent to the old pgrep -f openvpn, but it doesn't require the procps package, which is not included in Debian bookworm-slim by default. The change correctly solves the stated problem: making the healthcheck work without requiring additional packages.

Likely an incorrect or invalid review comment.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 1 file