Skip to content

Conversation

@wolf31o2
Copy link
Member

@wolf31o2 wolf31o2 commented Nov 21, 2025


Summary by cubic

Upgrade gouroboros to v0.140.0 and update ledger/metadata and blockfetch code to match its API/type changes. No functional behavior changes expected.

  • Dependencies

    • Bump github.com/blinklabs-io/gouroboros to v0.140.0.
  • Refactors

    • Cast certificate types to uint where required (stake registration, pool registration, ledger view).
    • Store PoolKeyHash as []byte when writing account metadata and update SetAccount calls accordingly.
    • Remove deprecated BlockFetch recv queue option; use library defaults.

Written for commit 9208f5f. Summary will update automatically on new commits.

Summary by CodeRabbit

  • Chores

    • Updated a dependency to a newer release.
    • Refined type handling in database operations for more consistent data representation.
    • Removed an internal connection option to streamline client behavior.
  • Style

    • Minor formatting cleanup in error construction for consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@wolf31o2 wolf31o2 requested a review from a team as a code owner November 21, 2025 15:48
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025

📝 Walkthrough

Walkthrough

Minor, localized edits for type consistency and small cleanup. Several certificate-related assignments change CertType to uint(...) casts in certs.go, pool.go, and ledger/view.go. account.go converts a PoolKeyHash array to a slice (pkh[:]) when storing and passing it. database/plugin/blob/aws/database.go has a formatting-only change to an error construction. blockfetch.go removes a WithRecvQueueSize(1000) option. go.mod bumps github.com/blinklabs-io/gouroboros from v0.139.0 to v0.140.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Changes are small, repetitive, and low logic density.
  • Areas to spot-check:
    • certs.go, pool.go, ledger/view.go — confirm uint(...) casts match model/schema expectations and serialization.
    • account.go — ensure pkh[:] slice type aligns with downstream storage and APIs.
    • go.mod — verify the dependency bump does not introduce breaking type changes.
    • blockfetch.go and database/plugin/blob/aws/database.go — cosmetic removals/formatting only.

Possibly related PRs

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: upgrading the gouroboros dependency to v0.140.0, which is the primary change in go.mod. Related code updates across multiple files are adapter changes necessitated by the dependency upgrade.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/upgrade-gouroboros

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80ae952 and 9208f5f.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (7)
  • blockfetch.go (0 hunks)
  • database/plugin/blob/aws/database.go (1 hunks)
  • database/plugin/metadata/sqlite/account.go (1 hunks)
  • database/plugin/metadata/sqlite/certs.go (1 hunks)
  • database/plugin/metadata/sqlite/pool.go (1 hunks)
  • go.mod (1 hunks)
  • ledger/view.go (1 hunks)
💤 Files with no reviewable changes (1)
  • blockfetch.go
🚧 Files skipped from review as they are similar to previous changes (6)
  • database/plugin/metadata/sqlite/pool.go
  • database/plugin/blob/aws/database.go
  • go.mod
  • database/plugin/metadata/sqlite/account.go
  • ledger/view.go
  • database/plugin/metadata/sqlite/certs.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: nilaway
  • GitHub Check: docker (ubuntu-latest, amd64)
  • GitHub Check: Analyze (go)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
@wolf31o2 wolf31o2 force-pushed the fix/upgrade-gouroboros branch from 80ae952 to 9208f5f Compare November 21, 2025 16:23
@wolf31o2 wolf31o2 merged commit f4c3a36 into main Nov 21, 2025
13 checks passed
@wolf31o2 wolf31o2 deleted the fix/upgrade-gouroboros branch November 21, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants