-
Notifications
You must be signed in to change notification settings - Fork 6
chore(deps): upgrade gouroboros to 0.139.0 #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
📝 WalkthroughWalkthroughThis pull request updates three Go module dependencies: blinklabs-io/gouroboros from v0.138.0 to v0.139.0, utxorpc/go-codegen from v0.17.0 to v0.18.1, and google.golang.org/protobuf from v1.36.9 to v1.36.10. The dependency updates drive API-level changes in utxorpc/submit.go, where SubmitTx and EvalTx handler functions are refactored from processing multiple transactions per request to handling a single transaction per request. This includes removal of transaction iteration loops, per-transaction error aggregation, and updates to BigInt encoding for fee representation. Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🧰 Additional context used🧬 Code graph analysis (1)utxorpc/submit.go (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The submit module SubmitTx and EvalTx now take single transactions as arguments. This allows us to use gRPC errors for error handling vs implementing custom handling in the protocol itself.
Closes #1010
Closes #1022
Summary by CodeRabbit