cortexar: force hard breakpoints

* As software breakpoints are not yet implemented, force hard breakpoints on cortexar targets

Author: litui

src/target/cortexar.c

@@ -312,6 +312,8 @@ static const uint16_t cortexar_spsr_encodings[5] = {
 /* Instruction Cache Invalidate ALL to Unification */
 #define CORTEXAR_ICIALLU 15U, ENCODE_CP_REG(7U, 5U, 0U, 0U)
 /* Data Cache Clean + Invalidate by Set/Way to Unification */
+#define CORTEXAR_DCCSW 15U, ENCODE_CP_REG(7U, 10U, 0U, 2U)
+/* Data Cache Clean + Invalidate by Set/Way to Unification */
 #define CORTEXAR_DCCISW 15U, ENCODE_CP_REG(7U, 14U, 0U, 2U)
 /* Address Translate Stage 1 Current state PL1 Read */
 #define CORTEXAR_ATS1CPR 15U, ENCODE_CP_REG(7U, 8U, 0U, 0U)
@@ -1642,7 +1644,15 @@ static int cortexar_breakwatch_set(target_s *const target, breakwatch_s *const b
 {
 	cortexar_priv_s *const priv = (cortexar_priv_s *)target->priv;
 
-	switch (breakwatch->type) {
+	/* 
+	 * Redirect soft to hard breakpoints (until soft breakpoints are working?)
+	 * GDB automatically selects soft breakpoints when an address is in RAM. This
+	 * code is needed to allow breakpoints to work when the break type can't be
+	 * configured in a GDB frontend (eg: in cortex-debug for VSCode).
+	 */
+	target_breakwatch_e bw_type = breakwatch->type == TARGET_BREAK_SOFT ? TARGET_BREAK_HARD : breakwatch->type;
+
+	switch (bw_type) {
 	case TARGET_BREAK_HARD: {
 		/* First try and find a unused breakpoint slot */
 		size_t breakpoint = 0;
@@ -1694,7 +1704,15 @@ static int cortexar_breakwatch_clear(target_s *const target, breakwatch_s *const
 {
 	cortexar_priv_s *const priv = (cortexar_priv_s *)target->priv;
 
-	switch (breakwatch->type) {
+	/* 
+	 * Redirect soft to hard breakpoints (until soft breakpoints are working?)
+	 * GDB automatically selects soft breakpoints when an address is in RAM. This
+	 * code is needed to allow breakpoints to work when the break type can't be
+	 * configured in a GDB frontend (eg: in cortex-debug for VSCode).
+	 */
+	target_breakwatch_e bw_type = breakwatch->type == TARGET_BREAK_SOFT ? TARGET_BREAK_HARD : breakwatch->type;
+
+	switch (bw_type) {
 	case TARGET_BREAK_HARD: {
 		/* Clear the breakpoint slot this used */
 		const size_t breakpoint = breakwatch->reserved[0];