Fixed failing test in PHP < 8

divineniiquaye · divineniiquaye · commit 1e58a75aea0f · 2021-08-06T01:59:05.000Z
diff --git a/tests/AnnotationLoaderTest.php b/tests/AnnotationLoaderTest.php
@@ -133,6 +133,8 @@ public function testAnnotationListenerWithResource($loader): void
     }
 
     /**
+     * @requires PHP >= 8.0
+     *
      * @dataProvider provideAnnotationLoader
      * @runInSeparateProcess
      */
@@ -176,16 +178,13 @@ public function testAnnotationLoaderWithFunction(): void
     }
 
     /**
+     * @requires PHP < 8.0
      * @runInSeparateProcess
      */
     public function testSettingConstructorNullInPhp7(): void
     {
-        if (PHP_VERSION_ID >= 80000) {
-            $this->markTestSkipped();
-        }
-
         $this->expectException(\RuntimeException::class);
-        $annotation = new AnnotationLoader();
+        new AnnotationLoader();
     }
 
     public function provideAnnotationLoader(): array

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,8 @@ public function testAnnotationListenerWithResource($loader): void`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`/**`
	`136`	`+ * @requires PHP >= 8.0`
	`137`	`+ *`
`136`	`138`	`* @dataProvider provideAnnotationLoader`
`137`	`139`	`* @runInSeparateProcess`
`138`	`140`	`*/`
`@@ -176,16 +178,13 @@ public function testAnnotationLoaderWithFunction(): void`
`176`	`178`	`}`
`177`	`179`
`178`	`180`	`/**`
	`181`	`+ * @requires PHP < 8.0`
`179`	`182`	`* @runInSeparateProcess`
`180`	`183`	`*/`
`181`	`184`	`public function testSettingConstructorNullInPhp7(): void`
`182`	`185`	`{`
`183`		`- if (PHP_VERSION_ID >= 80000) {`
`184`		`- $this->markTestSkipped();`
`185`		`- }`
`186`		`-`
`187`	`186`	`$this->expectException(\RuntimeException::class);`
`188`		`- $annotation = new AnnotationLoader();`
	`187`	`+ new AnnotationLoader();`
`189`	`188`	`}`
`190`	`189`
`191`	`190`	`public function provideAnnotationLoader(): array`