Commit ea986a8
committed
Merge #45: Allow fields to be opt-in rather than opt-out
67f5160 Add convenience defines for enabling byte sizes (Cory Fields)
812d428 Allow field opt-in (Cory Fields)
Pull request description:
This addresses the integration concern seen here: https://github.com/theuni/bitcoin/blob/minisketch-split/src/Makefile.minisketch.include#L4
If a field is explicitly enabled and disabled, disable takes precedence.
Defines are intended to work as such:
```
Default: All fields enabled
-DDISABLE_FIELD_3: All fields except 3 are enabled
-DENABLE_FIELD_3: All fields enabled
-DDISABLE_DEFAULT_FIELDS: Logical error, no fields enabled
-DDISABLE_DEFAULT_FIELDS -DENABLE_FIELD_3: Only field 3 enabled
-DDISABLE_DEFAULT_FIELDS -DENABLE_FIELD_2 -DENABLE_FIELD_3: Fields 2 and 3 are enabled
-DDISABLE_DEFAULT_FIELDS -DENABLE_FIELD_2 -DENABLE_FIELD_3 -DDISABLE_FIELD_3: Only field 2 enabled
```
ACKs for top commit:
sipa:
utACK 67f5160
Tree-SHA512: b9e719450dd91089a74f7c59918372f1a36ff7fe3e1b6969d0db257e475ac8df56be650526a29ba8e50db8e63f20be005fa872890dbd84c616ccee4462b6d3dcFile tree
20 files changed
+940
-362
lines changed- doc
- src
- fields
20 files changed
+940
-362
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
315 | 315 | | |
316 | 316 | | |
317 | 317 | | |
318 | | - | |
| 318 | + | |
319 | 319 | | |
320 | 320 | | |
321 | 321 | | |
322 | 322 | | |
323 | 323 | | |
324 | 324 | | |
325 | | - | |
| 325 | + | |
326 | 326 | | |
327 | 327 | | |
328 | 328 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
0 commit comments