Fix bitcoin-qt visual glitches on Wayland #904

diegoviola · 2025-10-16T07:19:00Z

The main window (BitcoinGUI) does not need to be passed to bringToFront(), doing so sets Qt::WindowStaysOnTopHint on the main window and causes it to flicker.

Fixes #903.

DrahtBot · 2025-10-16T07:19:08Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	pablomartin4btc

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

src/qt/guiutil.cpp

hebasto · 2025-10-16T12:37:04Z

src/qt/guiutil.cpp

-            w->setWindowFlags(flags|Qt::WindowStaysOnTopHint);
-            w->show();
-            w->setWindowFlags(flags);
            w->show();


Is it necessary now to call w->show(); here?

Would it be more clear to simply revert 15aa7d0?

@hebasto Yeah, I think a revert would also do the trick.

@hebasto compiling 30.0 with 15aa7d0 reverted, will confirm soon.

@hebasto Yeah, I can confirm that reverting 15aa7d0 solves the problem for me (on sway).

pablomartin4btc

Concept ACK

If you can, please check how this behaves on #817.

diegoviola · 2025-10-18T17:28:03Z

@pablomartin4btc can you please re-review?

The main window (BitcoinGUI) does not need to be passed to bringToFront(), doing so sets Qt::WindowStaysOnTopHint on the main window and causes it to flicker. Fixes #903.

pablomartin4btc

tested 095f920 and it fixes the problem.

I still need to check if this is the right approach, need to check against xcb and macOS. Also there are other places where bringToFront is being used, the rpcconsole has the same issue as the main window in wayland, so perhaps the fix has to be within bringToFront, need more time to test. Thanks for finding the issue and taking a look at this!

diegoviola · 2025-10-24T16:31:26Z

tested 095f920 and it fixes the problem.

Great! Thanks for confirming that.

I still need to check if this is the right approach, need to check against xcb and macOS.

Sure.

Also there are other places where bringToFront is being used, the rpcconsole has the same issue as the main window in wayland, so perhaps the fix has to be within bringToFront, need more time to test.

I am not able to reproduce the flickering with the rpcconsole specifically, but in a previous testing that I did removing these two lines helped with getting rid of some flickering, not all: https://github.com/bitcoin/bitcoin/blob/v30.0/src/qt/guiutil.cpp#L413-L414.

Can you please test if removing those help with the rpcconsole?

Thanks for finding the issue and taking a look at this!

You're welcome, thank you for your work as well.

hebasto

Tested 095f920, it breaks UX.

For example, on Fedora 43 with Gnome 49 and Wayland, follow these steps:

Run bitcoin-qt.
Hide the main window using the "Hide" command in context menu.
Click on "Receive" in the system tray icon menu.

On the master branch, the main window reappears.

With this PR, however, the main window remains hidden.

hebasto · 2025-11-21T12:47:39Z

From #904 (comment):

Would it be more clear to simply revert 15aa7d0?

Done in #914.

diegoviola · 2025-11-21T13:31:52Z

Closing in favor of #904.

diegoviola · 2025-11-21T15:12:41Z

For example, on Fedora 43 with Gnome 49 and Wayland

Ah, I haven't tested this on GNOME. I suspect the use of showNormal() likely helps with the desired window behavior, which is why the revert works better.

…for Wayland" 0672e72 Revert "gui, qt: brintToFront workaround for Wayland" (Hennadii Stepanov) Pull request description: This PR reverts a Wayland-specific workaround introduced in bitcoin-core/gui#831, which appears to break the UI, as reported in: - #33432 - bitcoin-core/gui#903 An alternative to bitcoin-core/gui#904, as suggested in bitcoin-core/gui#904 (comment). Fixes bitcoin-core/gui#903 ACKs for top commit: maflcko: review ACK 0672e72 🎩 Tree-SHA512: 3c2fba4a601de82b8c73553d54e93d133f9f474ee1f55a77320c0fc198735b68559859f7efeb125aa5282b8334bfa09f3927d6d7c984d2f87f54fa1ca45ee60e

diegoviola mentioned this pull request Oct 16, 2025

Qt6 version of Bitcoin Core (bitcoin-qt) flickers on Wayland #903

Closed

1 task

hebasto changed the title ~~qt: fix Wayland visual glitches~~ Fix Wayland visual glitches Oct 16, 2025

hebasto reviewed Oct 16, 2025

View reviewed changes

src/qt/guiutil.cpp Show resolved Hide resolved

hebasto reviewed Oct 16, 2025

View reviewed changes

diegoviola force-pushed the fix-qt-wayland-rendering-issue branch 2 times, most recently from 0fcab7d to 5535da8 Compare October 16, 2025 14:28

diegoviola requested a review from hebasto October 16, 2025 14:34

diegoviola force-pushed the fix-qt-wayland-rendering-issue branch from 5535da8 to 76e4b71 Compare October 16, 2025 14:38

pablomartin4btc reviewed Oct 16, 2025

View reviewed changes

diegoviola force-pushed the fix-qt-wayland-rendering-issue branch 2 times, most recently from 6542d5f to 949e953 Compare October 18, 2025 17:26

diegoviola requested a review from pablomartin4btc October 18, 2025 17:27

diegoviola force-pushed the fix-qt-wayland-rendering-issue branch 2 times, most recently from 6f71ab2 to 50f4b19 Compare October 18, 2025 19:26

qt: don't pass BitcoinGUI to bringToFront()

095f920

The main window (BitcoinGUI) does not need to be passed to bringToFront(), doing so sets Qt::WindowStaysOnTopHint on the main window and causes it to flicker. Fixes #903.

diegoviola force-pushed the fix-qt-wayland-rendering-issue branch from 50f4b19 to 095f920 Compare October 18, 2025 20:18

diegoviola changed the title ~~Fix Wayland visual glitches~~ Fix bitcoin-qt visual glitches on Wayland Oct 19, 2025

pablomartin4btc mentioned this pull request Oct 22, 2025

Bugfix - don't allow multiple dialogs for same tx in TransactionView #817

Draft

pablomartin4btc reviewed Oct 24, 2025

View reviewed changes

hebasto reviewed Nov 21, 2025

View reviewed changes

hebasto mentioned this pull request Nov 21, 2025

Revert "gui, qt: brintToFront workaround for Wayland" #914

Merged

diegoviola closed this Nov 21, 2025

Fix bitcoin-qt visual glitches on Wayland #904

Fix bitcoin-qt visual glitches on Wayland #904

Conversation

diegoviola commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews

Uh oh!

Uh oh!

hebasto Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

diegoviola Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

diegoviola Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

diegoviola Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

pablomartin4btc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

diegoviola commented Oct 18, 2025

Uh oh!

pablomartin4btc left a comment

Choose a reason for hiding this comment

Uh oh!

diegoviola commented Oct 24, 2025

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto commented Nov 21, 2025

Uh oh!

diegoviola commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

diegoviola commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

diegoviola commented Oct 16, 2025 •

edited

Loading

DrahtBot commented Oct 16, 2025 •

edited

Loading

pablomartin4btc left a comment •

edited

Loading

diegoviola commented Nov 21, 2025 •

edited

Loading