-
Notifications
You must be signed in to change notification settings - Fork 630
Description
The Cornerstone-6.16.2.zip archive doesn't match the 6.16.2 tag.
If you download that archive and unzip it, and look at an scss file it contains double quotes, but if you checkout tag 6.16.2 it has single quotes.
e.g. this is what it looks like if you check out the tag:
$ git checkout 6.16.2
HEAD is now at 2b67e3b0 Releasing 6.16.2
$ head -n 15 assets/scss/theme.scss
// =============================================================================
// STENCIL
// =============================================================================
// Tools
// -----------------------------------------------------------------------------
//
// 1. Import Citadel's toolkit for use.
//
// -----------------------------------------------------------------------------
@import '../../node_modules/@bigcommerce/citadel/dist/tools/toolkit'; // 1
@import 'tools/tools';
This is what it looks like if you view the same file in in the Cornerstone-6.16.2.zip archive:
$ head -n 15 ~/Downloads/Cornerstone-6.16.2/assets/scss/theme.scss
// =============================================================================
// STENCIL
// =============================================================================
// Tools
// -----------------------------------------------------------------------------
//
// 1. Import Citadel's toolkit for use.
//
// -----------------------------------------------------------------------------
@import "../../node_modules/@bigcommerce/citadel/dist/tools/toolkit"; // 1
@import "tools/tools";
Its the zip archive that appears to be incorrect. When browsing the code at the point of the release commit, the scss has single quotes:
https://github.com/bigcommerce/cornerstone/blob/2b67e3b0568517e58b814ffc1a13fe3ce40e16a5/assets/scss/theme.scss
When viewing the commits to master after 6.16.2 (6.16.2...master) there is a commit that reverts scss changes: "fix(storefront): SD-11213 restore indentation and quote rules to match BC Sass Style Guide" (a9a10a3)
So what should be used as the "official" 6.16.2 release? The 6.16.2 tag?