Skip to content

BBBModal: allow noFooter: false to hide existent footer #37

@Arthurk12

Description

@Arthurk12

Is your feature request related to a problem? Please describe.
Currently, the footer is displayed if noFooter is false or if there is a valid contentFooter element. So in this scenario, a BBBModal being rendered with a valid contentFooter element and with noFooter true will DISPLAY the footer, which is a bit confusing.

Describe the solution you'd like
Allow noFooter: true to actually hide the footer section even if there is a valid contentFooter element.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Affected component(s)
BBBModal

Proposed API / Usage Example
If applicable, provide a code snippet showing how the feature would be used.

// should display en empty footer section
<BBBModal
  title="My modal example"
/>

// should display the footer section
<BBBModal
  title="My modal example"
  footerContent={<BBButton label="Cancel" />}
/>

// should NOT display the footer section
<BBBModal
  title="My modal example"
  noFooter
/>

// should NOT display the footer section
<BBBModal
  title="My modal example"
  noFooter
  footerContent={<BBButton label="Cancel" />}
/>

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions