fix error on redirects - fixes #2

Author: mpociot

src/Outputs/Alert.php

@@ -2,13 +2,17 @@
 
 namespace BeyondCode\QueryDetector\Outputs;
 
-use Illuminate\Http\Response;
 use Illuminate\Support\Collection;
+use Symfony\Component\HttpFoundation\Response;
 
 class Alert implements Output
 {
     public function output(Collection $detectedQueries, Response $response)
     {
+        if ($response->isRedirection()) {
+            return;
+        }
+
         $content = $response->getContent();
 
         $outputContent = $this->getOutputContent($detectedQueries);

src/Outputs/Log.php

@@ -3,8 +3,8 @@
 namespace BeyondCode\QueryDetector\Outputs;
 
 use Log as LaravelLog;
-use Illuminate\Http\Response;
 use Illuminate\Support\Collection;
+use Symfony\Component\HttpFoundation\Response;
 
 class Log implements Output
 {

src/Outputs/Output.php

@@ -2,8 +2,8 @@
 
 namespace BeyondCode\QueryDetector\Outputs;
 
-use Illuminate\Http\Response;
 use Illuminate\Support\Collection;
+use Symfony\Component\HttpFoundation\Response;
 
 interface Output
 {

src/QueryDetector.php

@@ -3,9 +3,9 @@
 namespace BeyondCode\QueryDetector;
 
 use DB;
-use Illuminate\Http\Response;
 use Illuminate\Support\Collection;
 use Illuminate\Database\Eloquent\Builder;
+use Symfony\Component\HttpFoundation\Response;
 use Illuminate\Database\Eloquent\Relations\Relation;
 
 class QueryDetector

tests/QueryDetectorTest.php

@@ -2,11 +2,11 @@
 
 namespace BeyondCode\QueryDetector\Tests;
 
-use BeyondCode\QueryDetector\Tests\Models\Comment;
 use Route;
 use BeyondCode\QueryDetector\QueryDetector;
 use BeyondCode\QueryDetector\Tests\Models\Post;
 use BeyondCode\QueryDetector\Tests\Models\Author;
+use BeyondCode\QueryDetector\Tests\Models\Comment;
 
 class QueryDetectorTest extends TestCase
 {
@@ -207,4 +207,21 @@ public function it_ignores_whitelisted_relations_with_attributes()
 
         $this->assertCount(0, $queries);
     }
+
+    /** @test */
+    public function it_ignores_redirects()
+    {
+        Route::get('/', function (){
+            foreach (Post::all() as $post) {
+                $post->comments;
+            }
+            return redirect()->to('/random');
+        });
+
+        $this->get('/');
+
+        $queries = app(QueryDetector::class)->getDetectedQueries();
+
+        $this->assertCount(1, $queries);
+    }
 }

tests/TestCase.php

@@ -43,20 +43,6 @@ protected function getEnvironmentSetUp($app)
         ]);
 
         $app['config']->set('app.key', 'base64:6Cu/ozj4gPtIjmXjr8EdVnGFNsdRqZfHfVjQkmTlg4Y=');
-
-
-        $app['config']->set('logging.default', 'test');
-
-        $app['config']->set('logging.channels', [
-            'test' => [
-                'driver' => 'custom',
-                'via' => function () {
-                    $monolog = new Logger('test');
-                    $monolog->pushHandler(new TestHandler());
-                    return $monolog;
-                },
-            ],
-        ]);
     }