Skip to content

Commit d0254af

Browse files
thomasvlswiple-rules-gardener
authored andcommitted
Set output_files on the toolchain
This avoids having to use the deprecated argument to `proto_common.compile`. PiperOrigin-RevId: 547475903
1 parent f681717 commit d0254af

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

swift/internal/BUILD

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ proto_lang_toolchain(
1313
name = "proto_swift_toolchain",
1414
command_line = "--swift_out=$(OUT)",
1515
mnemonic = "ProtocGenSwift",
16+
output_files = "multiple",
1617
plugin = "@com_github_apple_swift_protobuf//:ProtoCompilerPlugin",
1718
plugin_format_flag = "--plugin=protoc-gen-swift=%s",
1819
progress_message = "Generating Swift sources for %{label}",

swift/internal/swift_protoc_gen_aspect.bzl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,6 @@ def _swift_protoc_gen_aspect_impl(target, aspect_ctx):
231231
additional_inputs = depset(direct = [transitive_module_mapping_file]),
232232
experimental_exec_group = _GENERATE_EXEC_GROUP,
233233
generated_files = pbswift_files,
234-
# ??? Docs says this is deprecated, but seems to be required
235-
plugin_output = aspect_ctx.bin_dir.path,
236234
proto_info = target_proto_info,
237235
proto_lang_toolchain_info = proto_lang_toolchain_info,
238236
)

0 commit comments

Comments
 (0)