From 170b1247efa13af78b6f8e141146542856332525 Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Thu, 4 Sep 2025 18:17:51 +0200 Subject: [PATCH 1/2] Don't flatten a depset unnecessarily --- rules/depsets/foo.bzl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/rules/depsets/foo.bzl b/rules/depsets/foo.bzl index 7b7c64c49..e0f7a58de 100644 --- a/rules/depsets/foo.bzl +++ b/rules/depsets/foo.bzl @@ -34,11 +34,10 @@ def _foo_binary_impl(ctx): foocc = ctx.executable._foocc out = ctx.outputs.out trans_srcs = get_transitive_srcs(ctx.files.srcs, ctx.attr.deps) - srcs_list = trans_srcs.to_list() ctx.actions.run( executable = foocc, arguments = [out.path] + [src.path for src in srcs_list], - inputs = srcs_list, + inputs = trans_srcs, tools = [foocc], outputs = [out], ) From 4b10cb950af3f4931c6648bf4ee5443d16498339 Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Thu, 4 Sep 2025 18:20:23 +0200 Subject: [PATCH 2/2] Update foo.bzl --- rules/depsets/foo.bzl | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/rules/depsets/foo.bzl b/rules/depsets/foo.bzl index e0f7a58de..70e6f75bb 100644 --- a/rules/depsets/foo.bzl +++ b/rules/depsets/foo.bzl @@ -34,9 +34,14 @@ def _foo_binary_impl(ctx): foocc = ctx.executable._foocc out = ctx.outputs.out trans_srcs = get_transitive_srcs(ctx.files.srcs, ctx.attr.deps) + + args = ctx.actions.args() + args.add(out) + args.add_all(trans_srcs) + ctx.actions.run( executable = foocc, - arguments = [out.path] + [src.path for src in srcs_list], + arguments = [args], inputs = trans_srcs, tools = [foocc], outputs = [out],