Merge branch 'master' into master

Author: pgrange

.github/workflows/bash_unit.yml

@@ -0,0 +1,11 @@
+name: bash_unit CI
+on:
+  push:
+
+jobs:
+  ubuntu:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Unit testing with bash_unit
+      run: FORCE_COLOR=true ./bash_unit tests/test*

README.adoc

@@ -111,6 +111,7 @@ Running tests in tests/test_core.sh
         Running test_fake_echo_stdin_when_no_params ... SUCCESS ✓ 
         Running test_fake_exports_faked_in_subshells ... SUCCESS ✓ 
         Running test_fake_transmits_params_to_fake_code ... SUCCESS ✓ 
+        Running test_should_pretty_format_even_when_LANG_is_unset ... SUCCESS ✓ 
 Overall result: SUCCESS ✓ 
 ```
 
@@ -174,6 +175,7 @@ ok ✓ test_fake_can_fake_inline
 ok ✓ test_fake_echo_stdin_when_no_params
 ok ✓ test_fake_exports_faked_in_subshells
 ok ✓ test_fake_transmits_params_to_fake_code
+ok - test_should_pretty_format_even_when_LANG_is_unset
 ```
 
 == How to write tests

bash_unit

@@ -243,9 +243,10 @@ pretty_failure() {
 pretty_format() {
   local color="$1"
   local pretty_symbol="$2"
-  local alt_symbol="$3"
+  local alt_symbol="${3:-}"
   local term_utf8=false
-  if is_terminal && [[ "$LANG" =~ .*UTF-8.* ]]
+#env
+  if is_terminal && [[ "${LANG:-}" =~ .*UTF-8.* ]]
   then
     term_utf8=true
   fi
@@ -280,7 +281,7 @@ color() {
 }
 
 is_terminal() {
-  [ -t 1 ] || [[ "${FORCE_COLOR}" == true ]]
+  [ -t 1 ] || [[ "${FORCE_COLOR:-}" == true ]]
 }
 
 text_format() {

tests/test_core.sh

@@ -150,6 +150,12 @@ EOF
   assert_equals 2 $(ps | "$GREP" pts | wc -l)
 }
 
+test_should_pretty_format_even_when_LANG_is_unset() {
+  # See https://github.com/pgrange/bash_unit/pull/81
+  unset LANG
+  assert "echo foo | pretty_format GREEN I"
+}
+
 if [[ "${STICK_TO_CWD}" != true ]]
 then
   # do not test for cwd if STICK_TO_CWD is true

tests/test_doc.sh

@@ -4,10 +4,8 @@ TEST_PATTERN='```test'
 OUTPUT_PATTERN='```output'
 LANG=C.UTF-8
 
-export FORCE_COLOR=false
 export STICK_TO_CWD=true
-BASH_UNIT="eval ./bash_unit"
-#BASH_UNIT="eval FORCE_COLOR=false ./bash_unit"
+BASH_UNIT="eval FORCE_COLOR=false ./bash_unit"
 
 prepare_tests() {
   mkdir /tmp/$$
@@ -21,14 +19,19 @@ prepare_tests() {
   while grep -E '^'"$TEST_PATTERN"'$' $remaining >/dev/null
   do
     ((++block))
-    run_doc_test  $remaining $swap |& sed '$a\' > $test_output$block
+    run_doc_test  $remaining $swap |& sed '$a\' | work_around_github_action_problem > $test_output$block
     doc_to_output $remaining $swap > $expected_output$block
     eval 'function test_block_'"$(printf %02d $block)"'() {
         assert "diff -u '"$expected_output$block"' '"$test_output$block"'"
       }'
   done
 }
 
+work_around_github_action_problem() {
+  # I have no idea what is happening with these broken pipes on github actions
+  grep -v '^/usr/bin/grep: write error: Broken pipe$'
+}
+
 function run_doc_test() {
   local remaining="$1"
   local swap="$2"