From 80c41d743634649423605b4fcc94093b904ff540 Mon Sep 17 00:00:00 2001 From: Niran Babalola Date: Mon, 8 Jun 2026 22:36:18 -0500 Subject: [PATCH] fix(load-test): default to base-load-tester binary --- benchmark/flags/flags.go | 2 +- clients/build-base-reth-node.sh | 10 +++++----- configs/examples/load-test.yml | 2 +- report/src/types.ts | 2 +- report/src/utils/formatters.tsx | 2 +- runner/payload/loadtest/load_test_worker.go | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/benchmark/flags/flags.go b/benchmark/flags/flags.go index 24d562e..03f8a0c 100644 --- a/benchmark/flags/flags.go +++ b/benchmark/flags/flags.go @@ -32,7 +32,7 @@ const ( // TxFuzz defaults const ( DefaultTxFuzzBin = "../tx-fuzz/cmd/livefuzzer/livefuzzer" - DefaultLoadTestBin = "./base-load-test" + DefaultLoadTestBin = "./base-load-tester" ) var ( diff --git a/clients/build-base-reth-node.sh b/clients/build-base-reth-node.sh index 60fd89c..054f1b8 100755 --- a/clients/build-base-reth-node.sh +++ b/clients/build-base-reth-node.sh @@ -43,9 +43,9 @@ echo "Checking out version: $BASE_RETH_NODE_VERSION" git checkout -f "$BASE_RETH_NODE_VERSION" # Build the binaries using cargo -echo "Building base-reth-node, base-builder, and base-load-test with cargo..." +echo "Building base-reth-node, base-builder, and base-load-tester with cargo..." cargo build --bin base-reth-node --bin base-builder --profile maxperf -cargo build -p base-load-tests --bin base-load-test --profile maxperf +cargo build -p base-load-tester-bin --bin base-load-tester --profile maxperf # Copy binaries to output directory echo "Copying binaries to output directory..." @@ -74,10 +74,10 @@ else exit 1 fi -if [ -f "target/maxperf/base-load-test" ]; then - cp target/maxperf/base-load-test "$FINAL_OUTPUT_DIR/" +if [ -f "target/maxperf/base-load-tester" ]; then + cp target/maxperf/base-load-tester "$FINAL_OUTPUT_DIR/" else - echo "No base-load-test binary found" + echo "No base-load-tester binary found" exit 1 fi diff --git a/configs/examples/load-test.yml b/configs/examples/load-test.yml index 143b977..19b3978 100644 --- a/configs/examples/load-test.yml +++ b/configs/examples/load-test.yml @@ -1,5 +1,5 @@ name: Load test throughput test -description: Test builder throughput using base-load-test binary as transaction generator +description: Test builder throughput using base-load-tester binary as transaction generator payloads: - name: Load Test type: load-test diff --git a/report/src/types.ts b/report/src/types.ts index 13d8c21..8f63426 100644 --- a/report/src/types.ts +++ b/report/src/types.ts @@ -113,7 +113,7 @@ export type BenchmarkRunWithStatus = BenchmarkRun & { status: RunStatus }; // Load tests // ----------------------------------------------------------------------------- // -// These types mirror the JSON written by the `base-load-test` Rust binary and +// These types mirror the JSON written by the `base-load-tester` Rust binary and // served by report-api at: // GET /api/v1/load-tests/:network -> LoadTestEntry[] // GET /api/v1/load-tests/:network/:timestamp -> LoadTestResult diff --git a/report/src/utils/formatters.tsx b/report/src/utils/formatters.tsx index 3485024..727d46f 100644 --- a/report/src/utils/formatters.tsx +++ b/report/src/utils/formatters.tsx @@ -189,7 +189,7 @@ const LOAD_TEST_TIMESTAMP_RE = /^(\d{4})-(\d{2})-(\d{2})-(\d{2})-(\d{2})-(\d{2})$/; export const parseLoadTestTimestamp = (raw: string): Date | null => { - // Format produced by base-load-test: "YYYY-MM-DD-HH-MM-SS" (UTC, no zone in + // Format produced by base-load-tester: "YYYY-MM-DD-HH-MM-SS" (UTC, no zone in // the string but the producer writes UTC). Returning null on parse failure // lets callers degrade to showing the raw string instead of crashing. const m = LOAD_TEST_TIMESTAMP_RE.exec(raw); diff --git a/runner/payload/loadtest/load_test_worker.go b/runner/payload/loadtest/load_test_worker.go index 2158ddd..8843b8e 100644 --- a/runner/payload/loadtest/load_test_worker.go +++ b/runner/payload/loadtest/load_test_worker.go @@ -52,7 +52,7 @@ type loadTestPayloadWorker struct { outputPath string } -// NewLoadTestPayloadWorker creates a worker that runs the base-load-test binary +// NewLoadTestPayloadWorker creates a worker that runs the base-load-tester binary // as an external transaction generator against the benchmark node's RPC. func NewLoadTestPayloadWorker( log log.Logger,