Skip to content

Commit b1edf7f

Browse files
committed
update README, TODOs, and CHANGELOG to reflect that the current plugin discovery mechanism should be improved, but should find every vim/neovim plugin available in nixpkgs
1 parent 208441f commit b1edf7f

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55

66
### Docs
77

8+
- Update docs regarding plugin discovery limitations
89
- Add note about plugin display names in the Lazy dashboard
9-
- Add section on alternative tools to the README
10+
- Add section on alternative tools
1011

1112

1213
## [0.2.0] - 2023-12-26

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ To provide nix store paths to the rest of the plugins in your configuration, upd
170170
```Lua
171171
{
172172
repo/my-cool-plugin.nvim,
173-
dir = require("lazy-nix-helper").get_plugin_path("my-cool-plugin"),
173+
dir = require("lazy-nix-helper").get_plugin_path("my-cool-plugin.nvim"),
174174
...
175175
}
176176
```
@@ -353,7 +353,7 @@ After moving your `init.lua` directly into your NixOS config and sourcing the re
353353

354354
Lazy-Nix-Helper can't currently find plugins installed by Nix on non-NixOS platforms.
355355

356-
Currently only plugins in the `vimplugin` or `lua5.1` package groups are found. That includes all the plugins that I use, but I think there are other package groups where neovim plugins can exist.
356+
Lazy-Nix-Helper's plugin discovery mechanism searches the current system's installed packages for packages prefixed with `vimplugin` or `lua5.1`. As of 2023-12-27 these are the only two prefixes used by the vimPlugin packageset in the unstable branch of nixpkgs. This works for now, but may break if a new prefix is added or existing prefixes are changed. It would be best to allow a list of plugin paths to be passed into the `setup()` function so that the nix store paths of neovim plugins could be provided declaratively by the NixOS config.
357357

358358
## Alternatives
359359

TODO.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55
- [x] naive implementation of nix store plugin discovery
66
- [ ] make plugin discovery work in a non-nixos environment with nix installed
7-
- [ ] more robust implementation of nix store plugin discovery
8-
- [ ] find plugins from all possible package groups, not just `vimplugin` and `lua5.1`
7+
- [ ] allow passing in a list of nix store paths so that plugin discovery is unnecessary
8+
- [x] find plugins from all possible package groups, not just `vimplugin` and `lua5.1` (turns out this is all the package groups)
99
- [x] get nix store plugin path given a plugin name
1010
- [x] can plugin names be made friendlier in configuration without risking collisions?
1111
can we let the user supply "my-plugin" while also checking the store for

0 commit comments

Comments
 (0)