Skip to content

Commit dc72312

Browse files
authored
MMS UseContainerSupport Flag (#352)
* MMS UseContainerSupport Flag * Test Coverage Exclusion: dmlc_patch
1 parent 24a1f63 commit dc72312

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

.coveragerc

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# .coveragerc to control coverage.py
2+
[run]
3+
omit =
4+
*/dmlc_patch/*
5+
6+
[report]
7+
exclude_lines =
8+
if __name__ == .__main__.:

src/sagemaker_xgboost_container/serving_mms.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,11 @@ def _set_mms_configs(is_multi_model, handler):
100100
_set_default_if_not_exist("SAGEMAKER_MAX_HEAP_SIZE", str(max_heap_size) + 'm')
101101
_set_default_if_not_exist("SAGEMAKER_MAX_DIRECT_MEMORY_SIZE", os.environ["SAGEMAKER_MAX_HEAP_SIZE"])
102102

103+
disable_container_support_flag = ""
104+
if "SAGEMAKER_DISABLE_CONTAINER_SUPPORT" in os.environ \
105+
and os.environ["SAGEMAKER_DISABLE_CONTAINER_SUPPORT"] == "true":
106+
disable_container_support_flag = " -XX:-UseContainerSupport"
107+
103108
MMS_CONFIG_FILE_PATH = get_mms_config_file_path()
104109

105110
# TODO: Revert config.properties.tmp to config.properties and add back in vmargs
@@ -115,7 +120,9 @@ def _set_mms_configs(is_multi_model, handler):
115120
+ " -XX:InitiatingHeapOccupancyPercent=25"
116121
+ " -Xms" + os.environ["SAGEMAKER_MAX_HEAP_SIZE"]
117122
+ " -Xmx" + os.environ["SAGEMAKER_MAX_HEAP_SIZE"]
118-
+ " -XX:MaxDirectMemorySize=" + os.environ["SAGEMAKER_MAX_DIRECT_MEMORY_SIZE"] + "\n")
123+
+ " -XX:MaxDirectMemorySize=" + os.environ["SAGEMAKER_MAX_DIRECT_MEMORY_SIZE"]
124+
+ disable_container_support_flag
125+
+ "\n")
119126
g.write(f.read())
120127
except Exception:
121128
pass

0 commit comments

Comments
 (0)