Skip to content

Commit 97e27f4

Browse files
committed
fix(cloudformation): render stack views on visibility change to prevent stale data
1 parent 08e23a1 commit 97e27f4

File tree

6 files changed

+15
-0
lines changed

6 files changed

+15
-0
lines changed

packages/core/src/awsService/cloudformation/ui/stackEventsWebviewProvider.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ export class StackEventsWebviewProvider implements WebviewViewProvider, Disposab
8080
})
8181
webviewView.onDidChangeVisibility(() => {
8282
if (webviewView.visible) {
83+
this.render()
8384
this.startAutoRefresh()
8485
} else {
8586
this.stopAutoRefresh()

packages/core/src/awsService/cloudformation/ui/stackOutputsWebviewProvider.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,12 @@ export class StackOutputsWebviewProvider implements WebviewViewProvider, Disposa
4444
this.view = webviewView
4545
webviewView.webview.options = { enableScripts: true }
4646

47+
webviewView.onDidChangeVisibility(() => {
48+
if (webviewView.visible) {
49+
this.render()
50+
}
51+
})
52+
4753
if (this.stackName) {
4854
await this.loadOutputs()
4955
} else {

packages/core/src/awsService/cloudformation/ui/stackOverviewWebviewProvider.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ export class StackOverviewWebviewProvider implements WebviewViewProvider, Dispos
8787

8888
webviewView.onDidChangeVisibility(() => {
8989
if (webviewView.visible && this.currentStackName) {
90+
this.render()
9091
this.startAutoRefresh()
9192
} else {
9293
this.stopAutoRefresh()

packages/core/src/awsService/cloudformation/ui/stackResourcesWebviewProvider.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ export class StackResourcesWebviewProvider implements WebviewViewProvider, Dispo
9999
private setupLifecycleHandlers(webviewView: WebviewView) {
100100
webviewView.onDidChangeVisibility(() => {
101101
if (webviewView.visible) {
102+
this.render()
102103
this.startAutoUpdate()
103104
} else {
104105
this.stopAutoUpdate()

packages/core/src/test/awsService/cloudformation/ui/stackOutputsWebviewProvider.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ describe('StackOutputsWebviewProvider', () => {
1919
options: {},
2020
html: '',
2121
},
22+
onDidChangeVisibility: sandbox.stub(),
23+
visible: true,
2224
}
2325
}
2426

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type": "Bug Fix",
3+
"description": "CloudFormation: render stack detail views on stack change"
4+
}

0 commit comments

Comments
 (0)