From ad7d7dda3b1cfc5f83770cbe9c6e7a550dec9c1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Joubert?= <14306+czj@users.noreply.github.com> Date: Wed, 11 Nov 2026 09:50:58 +0100 Subject: [PATCH] Allocate shape metadata on first write Every Shape and ShapeRef created an empty metadata Hash, though most never get any metadata. Loading the S3 and KMS APIs left 3,833 of them, about 0.6 MB of Ruby objects. Create the Hash on the first []= instead; [] reads nil as no metadata. Assisted-by: Claude Opus 5.5 [Claude Code] --- gems/aws-sdk-core/CHANGELOG.md | 2 ++ gems/aws-sdk-core/lib/seahorse/model/shapes.rb | 12 ++++++------ gems/aws-sdk-core/spec/seahorse/model/shapes_spec.rb | 6 ++++++ 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/gems/aws-sdk-core/CHANGELOG.md b/gems/aws-sdk-core/CHANGELOG.md index 7d1e15780d8..5800aae11bf 100644 --- a/gems/aws-sdk-core/CHANGELOG.md +++ b/gems/aws-sdk-core/CHANGELOG.md @@ -1,6 +1,8 @@ Unreleased Changes ------------------ +* Feature - Reduce memory usage of loaded service APIs by allocating shape metadata Hashes on first write. + * Feature - Reuse the chunk size header of full chunks when streaming request bodies with checksum trailers. 3.268.0 (2026-11-11) diff --git a/gems/aws-sdk-core/lib/seahorse/model/shapes.rb b/gems/aws-sdk-core/lib/seahorse/model/shapes.rb index 5475c77bbe3..ef4418832f9 100644 --- a/gems/aws-sdk-core/lib/seahorse/model/shapes.rb +++ b/gems/aws-sdk-core/lib/seahorse/model/shapes.rb @@ -9,7 +9,7 @@ module Shapes class ShapeRef def initialize(options = {}) - @metadata = {} + @metadata = nil @required = false @deprecated = false @location = nil @@ -84,7 +84,7 @@ def location_name= location_name # Gets metadata for the given `key`. def [](key) - if @metadata.key?(key.to_s) + if @metadata&.key?(key.to_s) @metadata[key.to_s] elsif @shape @shape[key.to_s] @@ -93,7 +93,7 @@ def [](key) # Sets metadata for the given `key`. def []=(key, value) - @metadata[key.to_s] = value + (@metadata ||= {})[key.to_s] = value end end @@ -101,7 +101,7 @@ def []=(key, value) class Shape def initialize(options = {}) - @metadata = {} + @metadata = nil options.each_pair do |key, value| if respond_to?("#{key}=") send("#{key}=", value) @@ -122,12 +122,12 @@ def initialize(options = {}) # Gets metadata for the given `key`. def [](key) - @metadata[key.to_s] + @metadata && @metadata[key.to_s] end # Sets metadata for the given `key`. def []=(key, value) - @metadata[key.to_s] = value + (@metadata ||= {})[key.to_s] = value end end diff --git a/gems/aws-sdk-core/spec/seahorse/model/shapes_spec.rb b/gems/aws-sdk-core/spec/seahorse/model/shapes_spec.rb index 40815306285..3e38505471d 100644 --- a/gems/aws-sdk-core/spec/seahorse/model/shapes_spec.rb +++ b/gems/aws-sdk-core/spec/seahorse/model/shapes_spec.rb @@ -52,6 +52,12 @@ module Shapes expect(ref['key']).to eq('value') end + it 'returns nil for metadata that was never set' do + expect(ShapeRef.new[:key]).to be(nil) + expect(ShapeRef.new(shape: Shape.new)[:key]).to be(nil) + expect(Shape.new[:key]).to be(nil) + end + it 'can be populated via .new' do shape = double('shape') ref = ShapeRef.new(